-
Notifications
You must be signed in to change notification settings - Fork 215
Extend-wasm-ttl #888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend-wasm-ttl #888
Conversation
@briwylde08 This is ready for review |
Thanks for the submission! We'll get it assigned and reviewed. Note that reviews may take longer than normal as we have a lot of submissions to get through! |
Hello, Just checking in for the status of the review |
Hey @Myestery! Sorry for the delay on the review on this. Let me check! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, there @Myestery! This is looking really good! A nice, simple, straight-forward guide. I left a couple minor suggestions for improved markdown file links. I'd also like to see just a bit more information/detail about the SorobanDataBuilder()
part.
Other than that, this one's nearly ready to go! Thanks for the contribution!
Hi @ElliotFriend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wonderful! Thanks for the contribution, @Myestery!
Thank you @Myestery! As usual, we'll take the award conversation back to the corresponding issue! |
* extend footprint operation * format doc * use absolute link to extend ttl op * Editorial and links * explain more about soroban data * chore: Improve documentation on extending Soroban TTL --------- Co-authored-by: Bri <92327786+briwylde08@users.noreply.github.com>
fix #618