Skip to content

Conversation

Myestery
Copy link
Contributor

@Myestery Myestery commented Aug 7, 2024

fix #618

@Myestery
Copy link
Contributor Author

Myestery commented Aug 7, 2024

@briwylde08 This is ready for review

@briwylde08
Copy link
Contributor

Thanks for the submission! We'll get it assigned and reviewed. Note that reviews may take longer than normal as we have a lot of submissions to get through!

@briwylde08 briwylde08 requested a review from anataliocs August 7, 2024 18:07
@Myestery
Copy link
Contributor Author

Hello, Just checking in for the status of the review

@briwylde08
Copy link
Contributor

Hey @Myestery! Sorry for the delay on the review on this. Let me check!

Copy link
Contributor

@ElliotFriend ElliotFriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, there @Myestery! This is looking really good! A nice, simple, straight-forward guide. I left a couple minor suggestions for improved markdown file links. I'd also like to see just a bit more information/detail about the SorobanDataBuilder() part.

Other than that, this one's nearly ready to go! Thanks for the contribution!

@Myestery
Copy link
Contributor Author

Hi @ElliotFriend
I added more explanation about the SorobanDataBuilder part

Copy link
Contributor

@ElliotFriend ElliotFriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful! Thanks for the contribution, @Myestery!

@briwylde08
Copy link
Contributor

Thank you @Myestery! As usual, we'll take the award conversation back to the corresponding issue!

@briwylde08 briwylde08 merged commit 6048e91 into stellar:main Aug 27, 2024
1 check passed
janewang pushed a commit that referenced this pull request Sep 12, 2024
* extend footprint operation

* format doc

* use absolute link to extend ttl op

* Editorial and links

* explain more about soroban data

* chore: Improve documentation on extending Soroban TTL

---------

Co-authored-by: Bri <92327786+briwylde08@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a guide for extending a deployed contract’s Wasm code TTL with code

3 participants