State archival on the client side #831
Conversation
|
@briwylde08 this is ready for review |
|
Thank you! We'll get this assigned and reviewed! |
|
Hello @briwylde08 |
|
Hi @Myestery, apologies, we are a little behind on reviews. I'll get it assigned next week! |
|
Little reminder @briwylde08 that this PR hasn't been assigned yet |
Shaptic
left a comment
Shaptic
left a comment
There was a problem hiding this comment.
Sorry for the delay in reviews; with Protocol 22 coming we have a pretty intense schedule crunch. I've finally finished the first-pass review! This guide looks good, most of my critiques involve the fact that a lot of these could be delegated to cross-references to focus on the extra stuff this article is adding.
|
Hi @Myestery! Just checking in on this one. Are you able to implement the suggested changes? |
|
Yeah, |
Simplify and clarify the state archival guide in dapps by removing redundant information and reorganizing the content. Also update the code samples to reflect the latest changes in the contract implementation.
|
Hello @Shaptic |
Shaptic
left a comment
Shaptic
left a comment
There was a problem hiding this comment.
Great work @Myestery! I just left two tiny comments and otherwise think this is really useful content that can be merged 👍 please resolve them and I'll let @briwylde08 hit the merge button once that's done :)
|
All done @Shaptic |
|
@briwylde08 this is good to go! Thank you again @Myestery :) |
|
Thank you both so much! |
3 participants
fix #596