feature: add auto restore functionality for contract client #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix name Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com>
better description Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com>
Better auto restore failure message. Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com>
Shaptic
reviewed
Jun 13, 2024
Co-authored-by: George <Shaptic@users.noreply.github.com>
Co-authored-by: George <Shaptic@users.noreply.github.com>
Shaptic
reviewed
Jun 13, 2024
Co-authored-by: George <Shaptic@users.noreply.github.com>
Shaptic
approved these changes
Jun 13, 2024
|
@BlaineHeffron I can merge these as soon as e2e tests pass 👍 |
|
There was a missing check that didnt get caught in the merge from the toXDR / fromXDR PR. Should be good now! |
|
Actually looks like the unit test I had written for this PR is failing, let me look into that. |
|
Good to go now |
Merged
BlaineHeffron
added a commit
to AhaLabs/js-stellar-sdk
that referenced
this pull request
Jun 20, 2024
Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com> Co-authored-by: blaineheffron <baheffron@gmail.com> Co-authored-by: George <Shaptic@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #974, because Blaine is out and I don't have permission to push to his fork. This just resolves the conflicts with
master.