Skip to content

Change signature of ClientOption.signTransaction to be able to pass KeyPair #1063

Open

Description

basicNodeSigner is a great helper, but currently it is hard to find and is not referenced anywhere.
I propose to should change the signature of signTransaction to current function | KeyPair and if user passes keypair, we simply use basicNodeSigner as the signer function. Currently, you need to dig into the source code to understand how it works. I like that we make it very extensible, but IMO in a lot of cases (especially testing), people just want to sign with a key pair.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

Type

No type

Projects

  • Status

    Backlog (Not Ready)

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions