Upgrade XDR to Protocol 21 #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +13.6 kB (0%) Total Size: 3.21 MB
|
sreuland
reviewed
Apr 26, 2024
| @@ -14,7 +14,7 @@ XDR_FILES_CURR= \ | |||
| Stellar-contract-config-setting.x | |||
| XDR_FILES_LOCAL_CURR=$(addprefix xdr/curr/,$(XDR_FILES_CURR)) | |||
|
|
|||
| XDR_BASE_URL_NEXT=https://github.com/stellar/stellar-xdr/raw/bb54e505f814386a3f45172e0b7e95b7badbe969 | |||
| XDR_BASE_URL_NEXT=https://github.com/stellar/stellar-xdr/raw/4bd4827b3361f266d295cbc83c5d7f7396d782d9 | |||
There was a problem hiding this comment.
is it necessary to bump the 'next' codeline in this pr scope, seems the intent is to just change the xdr version for client usage which is 'curr' ?
There was a problem hiding this comment.
hmm I guess technically not but there is no harm either in case someone wanted to use the SDK to dev on next for whatever reason 🤷 imo it's nice to keep them updated at the same time
sreuland
approved these changes
Apr 26, 2024
This was referenced May 6, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the XDR to stellar/stellar-xdr@1a04392.