-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace set-output usage with GITHUB_OUTPUT #252
Replace set-output usage with GITHUB_OUTPUT #252
Conversation
…the GITHUB_OUTPUT file
Thanks Andrew! LGTM. (BTW: Great work with the Arc browser. Love it more and more. ❤️ ) |
Hopefully I fixed the tests :) I’m not the world’s best shell programmer so I just kinda yolo’d it on the test updates. And thank you for the kind words about Arc! I’m so happy to hear you love it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Supberb work, Andrew. 👏
Tests in my own repos also show no regression.
Will merge this to master
and tag a new version soon.
(Still have to decide, if this is just a patch release or a major release. Others mentioned that GitHub Enterprise workers need updating: #246 (comment) 🤔 )
# While it is likely the GitHub hosted runners will use master as the default branch, | ||
# locally anyone may change that. So for tests lets grab whatever is currently set | ||
# globally. This should also ensure that changes to the GitHub hosted runners' | ||
# config do not break tests in the future. | ||
if [[ -z $(git config init.defaultBranch) ]]; then | ||
git config --global init.defaultBranch "main" | ||
fi | ||
|
||
export FAKE_DEFAULT_BRANCH=$(git config init.defaultBranch) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. 👏
I think on my machine I added a config that repos under the path always use master
as the default branch.
As nobody else run these tests before, this didn't come up.
Thanks for the fix.
Thank you! I'll update our repo to the new version later today |
If you reference just @v4 you get the update automatically btw. |
@stefanzweifel I have updated our references to
|
Ah, never mind. I see that you had to set it back to the old format for enterprise users. I’ll update our reference to v4.15.2 to get the changes and silence the warnings for ourselves. |
Yeah, my bad for mentioning you can/should reference The old syntax is being deprecated by GitHub in June 2023. I will probably remove it – again – by the end of the year, as the majority of Enterprise users will then probably have upgraded their runners. (Also wanna start a discussion with GitHub, on how to handle such changes in the future better) |
See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ and the recommended migration.
Should fix #250.
This should prevent warnings (and in the future errors) appearing in GitHub summaries.
Generated using
fastmod
Before
After