Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some useful things #343

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jersiovic
Copy link

Hi,
This PR contains the improvemnets I did for using it in our project. I provide you a PR just in case you are interested on merging it.

The new features added are:

  • Added the possibility of stablish a range of ip adressed in comma separated format.
  • Removed the need of adding a key in cache for rules with period 0
  • Added HttpStatusCodeForLimitZeroRequests option, for returning a different https status code for matching rules with limit 0. In our case in that case we need to return a 404.
  • Added DiscardEndpointGeneralRulesWhenExistsIPOrClienIdRule . It defines if general rules for an endpoint should be discarded if an ip o client id rule is defined for the same endpoint. By default they are only discarded if there is any rule for the same period.

Thank you for sharing your code on github

…ests option and DiscardEndpointGeneralRulesWhenExistsIPOrClienIdRule option
@jersiovic jersiovic closed this Jul 1, 2022
@jersiovic jersiovic reopened this Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant