Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hard-coded text strings that are not i18nized #2348

Open
goldibex opened this issue Jan 16, 2018 · 0 comments
Open

Fix hard-coded text strings that are not i18nized #2348

goldibex opened this issue Jan 16, 2018 · 0 comments

Comments

@goldibex
Copy link
Contributor

Original issue is #1929. The outcome of this issue is to review each of these items, and if there is still a hardcoded string, remove it and replace it with a translation.

Original issue content from #1929 follows below.


There are a lot of hard-coded strings in the code of Steemit condenser.
These may not be bugs, but they can't be translated.
For example: "Fill convert request" is one of hard-coded strings.

Period and space are hard-coded.
For languages which use alphabet similar to English, these are not problem, but for some languages such as Japanese and Chinese these are not needed.
They uses "。" instead of ".".
These symbols also must be included to locales files.

Here I list hard-coded strings that become problems in translation.
This list is not complete, but it contains many of hard-coded strings.
But it may contain messages which is not visible to users.

https://github.com/steemit/condenser/blob/master/src/app/components/cards/PostFull.jsx
line 216: content_body = 'Not available for legal reasons.'

https://github.com/steemit/condenser/blob/master/src/app/components/cards/TransferHistoryRow.jsx
line 98: description_start += Claim rewards: ${rewards_str};
line 103: description_start += Fill convert request: ${data.amount_in} for ${data.amount_out};
line 107: description_start += Paid ${data.open_pays} for ${data.current_pays};
line 110: description_start += Paid ${data.current_pays} for ${data.open_pays};
line 115: description_start += ${benefactor_reward} STEEM POWER for ${data.author}/${data.permlink};

https://github.com/steemit/condenser/blob/master/src/app/components/elements/ChangePassword.jsx
line 53: nameError: "Account name can't be verified right now due to server failure. Please try again later."

https://github.com/steemit/condenser/blob/master/src/app/components/elements/ConvertToSteem.jsx
line 45:

{tt('converttosteem_jsx.DEBT_TOKEN_will_be_unavailable', {DEBT_TOKEN})}.


period
line 47:

{tt('converttosteem_jsx.this_is_a_price_feed_conversion')}.


period

https://github.com/steemit/condenser/blob/master/src/app/components/elements/ReplyEditor.jsx
line 238: this.setState({progress: {error: 'Please insert only image files.'}})
line 569: errorCallback('HTML posts must begin with and end with ')
line 582: errorCallback('Please remove the following HTML elements from your post: ' + Array(...rtags.htmltags).map(tag => <${tag}>).join(', '))

https://github.com/steemit/condenser/blob/master/src/app/components/elements/SidebarLinks.jsx
line 6:

Links

;
line 10:
  • <a className="c-sidebar__link" href={'/@' + username}>My blog

  • line 11:
  • <a className="c-sidebar__link" href={'/@' + username + '/transfers'}>My wallet
  • https://github.com/steemit/condenser/blob/master/src/app/components/elements/SidebarNewUsers.jsx
    line 6:

    New to Steemit?


    line 10:
  • Quick start guide

  • line 11:
  • <a className="c-sidebar__link" href="https://steem.io"&gt;The blockchain

  • line 12:
  • FAQs

  • line 13:
  • Sign up
  • https://github.com/steemit/condenser/blob/master/src/app/components/elements/Voting.jsx
    line 154: Flag

    https://github.com/steemit/condenser/blob/master/src/app/components/modules/PromotePost.jsx
    line 75:

    {tt('promote_post_jsx.spend_your_DEBT_TOKEN_to_advertise_this_post', {DEBT_TOKEN})}.


    period

    https://github.com/steemit/condenser/blob/master/src/app/components/modules/SidebarModule.jsx
    line 9:

    Links React Component

    https://github.com/steemit/condenser/blob/master/src/app/components/modules/SignUp.jsx
    line 16:

    Due to server maintenance we are running in read only mode. We are sorry for the inconvenience.


    and many other hard-coded strings in this file. You can find them easily.

    https://github.com/steemit/condenser/blob/master/src/app/components/modules/TermsAgree.jsx
    line 34:

    Terms and Service


    and many other hard-coded strings in this file. You can find them easily.

    https://github.com/steemit/condenser/blob/master/src/app/components/modules/UserWallet.jsx
    line 276: Your current rewards: {rewards_str}

    https://github.com/steemit/condenser/blob/master/src/app/components/pages/Approval.jsx
    line 22:

    Thanks for confirming your email!

    After validating your sign up request with us we'll look it over for approval. As soon as your turn is up and you're approved, you'll be sent a link to finalize your account!

    You'll be among the earliest members of the Steemit community!


    line 28:

    Thanks for confirming your phone number!

    You're a few steps away from getting to the top of the list. Check your email and click the email validation link.

    After validating your sign up request with us we'll look it over for approval. As soon as your turn is up and you're approved, you'll be sent a link to finalize your account!

    You'll be among the earliest members of the Steemit community!

    https://github.com/steemit/condenser/blob/master/src/app/components/pages/CreateAccount.jsx
    line 152: name_error: "Account name can't be verified right now due to server failure. Please try again later."
    line 184:

    Membership to Steemit.com is now under invitation only because of unexpectedly high sign up rate.


    line 194:

    Cryptography test failed

    We will be unable to create your Steem account with this browser.

    The latest versions of <a href="https://www.google.com/chrome/"&gt;Chrome&lt;/a> and <a href="https://www.mozilla.org/en-US/firefox/new/"&gt;Firefox&lt;/a> are well tested and known to work with steemit.com.


    line 208:

    You need to Logout before you can create another account.

    Please note that Steemit can only register one account per verified user.


    and many other hard-coded strings in this file. You can find them easily.

    https://github.com/steemit/condenser/blob/master/src/app/components/pages/NotFound.jsx
    line 28:

    Sorry! This page doesn't exist.

    Not to worry. You can head back to <a style={{fontWeight: 800}} href="/">our homepage, or check out some great posts.


    line 33:
  • new posts

  • line 34:
  • hot posts

  • line 35:
  • trending posts

  • line 36:
  • promoted posts

  • line 37:
  • active posts
  • https://github.com/steemit/condenser/blob/master/src/app/components/pages/PickAccount.jsx
    line 72: return res && res.length > 0 ? 'Account name is not available' : '';
    line 80: name_error: "Account name can't be verified right now due to server failure. Please try again later."
    line 91:

    LOADING..


    line 110:

    The creation of new accounts is temporarily disabled.


    and many other hard-coded strings in this file. You can find them easily.

    https://github.com/steemit/condenser/blob/master/src/app/components/pages/Post.jsx
    line 82:

    {tt('promote_post_jsx.this_post_was_hidden_due_to_low_ratings')}.{' '}
    period and space
    line 115: {showNegativeComments ? tt('post_jsx.now_showing_comments_with_low_ratings') : tt('post_jsx.comments_were_hidden_due_to_low_ratings')}.{' '}
    period and space
    line 142:

    Sorry! This page doesnt exist.

    Not to worry. You can head back to <a style={{fontWeight: 800}} href="/">our homepage, or check out some great posts.


    line 147:
  • new posts

  • line 148:
  • hot posts

  • line 149:
  • trending posts

  • line 150:
  • promoted posts

  • line 151:
  • active posts

  • line 167: {tt('g.next_7_strings_single_block.authors_get_paid_when_people_like_you_upvote_their_post')}.
    period

    https://github.com/steemit/condenser/blob/master/src/app/components/pages/PostsIndex.jsx
    line 97: emptyText =

    {'No ' + topics_order + (category ? ' #' + category : '') + ' posts found'}
    ;
    line 177: {showSpam ? tt('g.next_3_strings_together.show_less') : tt('g.next_3_strings_together.show_more')}{' ' + tt('g.next_3_strings_together.value_posts')}
    space

    https://github.com/steemit/condenser/blob/master/src/app/components/pages/Privacy.jsx
    line 8:

    Steemit, Inc Privacy Policy


    and many other hard-coded strings in this file. You can find them easily.

    https://github.com/steemit/condenser/blob/master/src/app/components/pages/RecoverAccountStep1.jsx
    line 195: {show_social_login === 'both' ?

    {tt('recoveraccountstep1_jsx.login_with_facebook_or_reddit_media_to_verify_identity')}.


    period
    line 198: })}.

    }
    period

    https://github.com/steemit/condenser/blob/master/src/app/components/pages/Support.jsx
    line 12: {tt('g.please_email_questions_to')} contact@steemit.com.
    period

    https://github.com/steemit/condenser/blob/master/src/app/components/pages/Tos.jsx
    line 8:

    Steemit Terms of Service


    and many other hard-coded strings in this file. You can find them easily.

    https://github.com/steemit/condenser/blob/master/src/app/components/pages/UserProfile.jsx
    line 264: tab_content = {tt('user_profile.user_hasnt_had_any_replies_yet', {name: accountname}) + '.'};
    period

    https://github.com/steemit/condenser/blob/master/src/app/components/pages/Welcome.jsx
    line 10:

    Welcome to

    line 12:
    Come for the rewards. Stay for the community.

    https://github.com/steemit/condenser/blob/master/src/app/components/pages/Witnesses.jsx
    line 131: {tt('witnesses_jsx.you_have_votes_remaining', {count: witness_vote_count})}.{' '}
    period and space
    line 132: {tt('witnesses_jsx.you_can_vote_for_maximum_of_witnesses')}.
    period
    line 157:

    {tt('witnesses_jsx.if_you_want_to_vote_outside_of_top_enter_account_name')}.


    period
    line 198: {this.state.proxyFailed &&

    {tt('witnesses_jsx.proxy_update_error')}.

    }
    period
    line 236: confirm: proxy.length ? "Set proxy to: " + proxy : "You are about to remove your proxy.",

    https://github.com/steemit/condenser/blob/master/src/app/redux/AuthSaga.js
    line 117: if (!account) throw new Error('Account not found')

    https://github.com/steemit/condenser/blob/master/src/app/redux/Transaction.js
    line 54: let errorKey = 'Transaction broadcast error.';
    line 59: errorKey = 'You already voted for this post';
    line 65: errorKey = 'You may only post once per minute.'
    line 71: errorKey = 'Insufficient balance.'
    line 76: errorKey = 'Account requires 10x the account creation fee in Steem Power (approximately 300 SP) before it can power down.'
    line 94: errorStr = Transaction failed: ${err_lines[1]};
    line 100: errorKey = "Steem account doesn't exist.";
    line 101: errorStr = "Transaction failed: Steem account doesn't exist.";
    line 105: errorKey = "Not your valid active key.";
    line 106: errorStr = "Transaction failed: Not your valid active key.";

    https://github.com/steemit/condenser/blob/master/src/app/redux/TransactionSaga.js
    line 62: if(!memo_private) throw new Error('Unable to encrypt memo, missing memo private key')
    line 64: if(!account) throw new Error(Unknown to account ${operation.to})
    line 515: onError('Unknown account ' + account)
    line 519: onError('Your new password should not be a WIF')
    line 523: onError('Your new password should not be a Public Key')
    line 578: onError('Account not found')
    line 598: onError('Missing old key, not sure what to replace')
    line 684: onError(Incorrect Password)
    line 685: throw new Error('Trying to update a memo without a signing key?')
    line 711: onError('Account not found')
    line 715: onError(Incorrect Password)
    line 716: throw new Error('Have to pass owner key in order to change meta')

    https://github.com/steemit/condenser/blob/master/src/app/redux/UserSaga.js
    line 150: yield put(user.actions.loginError({ error: 'Username does not exist' }))
    line 198: yield put(user.actions.loginError({ error: 'Hello. Your account may have been compromised. We are working on restoring an access to your account. Please send an email to support@steemit.com.' }))
    line 233: yield put(user.actions.loginError({ error: 'This login gives owner or active permissions and should not be used here. Please provide a posting only login.' }))
    line 319: throw 'Login will not be saved, posting key is the same as active key'
    line 323: throw 'Login will not be saved, posting key is the same as owner key'
    line 464: progress({error: 'Unable to contact the server.'})

    https://github.com/steemit/condenser/blob/master/src/app/utils/SlateEditor/Iframe.js
    line 109: placeholder="Enter a YouTube or Vimeo URL..."

    https://github.com/steemit/condenser/blob/master/src/app/utils/ChainValidation.js
    line 24: return 'Use caution sending to this account. Please double check your spelling for possible phishing. ';
    line 56: return suffix = 'Do not use private keys in memos. ';
    line 59: return suffix = 'Do not use passwords in memos. ';
    line 62: return suffix = 'Please do not include what appears to be a private key or password. '

    https://github.com/steemit/condenser/blob/master/src/app/utils/ExtractMeta.js
    line 67: if(about == null) about = "Join thousands on steemit who share, post and earn rewards.";
    line 71: const desc = The latest posts from ${name}. Follow me at @${account.name}. ${about};

    https://github.com/steemit/condenser/blob/master/src/app/utils/SanitizeConfig.js
    line 32: export const noImageText = '(Image not shown due to low ratings)'
    line 81: sanitizeErrors.push('Invalid iframe URL: ' + srcAtty)
    line 90: sanitizeErrors.push('An image in this post did not save properly.')

    https://github.com/steemit/condenser/blob/master/src/server/api/account_recovery.js
    line 23: this.body = 'please provide account name';

    https://github.com/steemit/condenser/blob/master/src/server/api/general.js
    line 90: this.body = JSON.stringify({error: 'New signups are temporary disabled.'});
    line 97: this.body = JSON.stringify({error: 'Unauthorized'});
    line 107: this.body = JSON.stringify({error: 'Conflict'});
    line 125: throw new Error("We can't find your sign up request. You either haven't started your sign up application or weren't approved yet.");
    line 148: throw new Error('Only one Steem account allowed per IP address every 10 minutes');
    line 445: this.body = 'missing logged in account';
    line 451: if (json.length > 1024) throw new Error('the data is too long');

    https://github.com/steemit/condenser/blob/master/src/server/api/oauth.js
    line 114: this.body = 'We cannot verify the user account. Please contact support@steemit.com';
    line 119: this.body = 'We cannot verify the user account. Please contact support@steemit.com';
    line 155: this.flash = {success: 'Successfully authenticated with Facebook'};
    line 214: this.body = 'We cannot verify the user account. Please contact support@steemit.com';
    line 219: this.body = 'We cannot verify the user account. Please contact support@steemit.com';

    https://github.com/steemit/condenser/blob/master/src/server/sign_up_pages/enter_confirm_email.jsx
    line 52: this.flash = { success: "Email has already been verified" };
    line 60: this.body = 'Confirmation code expired. Please re-submit your email for verification.';
    line 157: this.flash = {alert: "Your account has already been created."};
    line 165: this.flash = { error: "Your account has not been approved yet." };
    line 168: this.flash = { error: "Issue with your sign up status." };
    line 173: this.flash = { error: "This is not a valid sign up code. Please click the link in your welcome email." };
    line 182: this.flash = { error: "Please select your account name" };
    line 189: this.flash = { error: ${picked_account_name} is already taken, please try another name };
    line 205: Your email address, please
    line 208: We use this to contact you and verify account ownership if this account is ever compromised. We'll send a confirmation link, so please use a valid email.
    line 261: this.flash = { error: "Please provide an email address" };
    line 278: error: "Failed captcha verification, please try again"
    line 293: this.flash = { error: "Not valid email address" };

    https://github.com/steemit/condenser/blob/master/src/server/sign_up_pages/enter_confirm_mobile.jsx
    line 58: this.flash = { error: "User session not found, please make sure you have cookies enabled in your browser for this website" };
    line 67: this.flash = { error: "Wrong confirmation code" };
    line 75: this.flash = { error: "Confirmation code has been expired" };
    line 90: this.flash = { error: "This phone number has already been used" };
    line 133: Almost there!
    line 138:

    We need to send you a quick text.


    line 140:

    With each Steemit account comes a free initial grant of Steem Power! Phone verification helps cut down on spam accounts.


    line 144:

    Your phone number will not be used for any other purpose other than account verification and (potentially) account recovery should your account ever be compromised.


    line 150: Country Code
    line 154: Phone number
    line 158: Examples: 541-754-3010 | 89-636-48018
    line 162: * Land lines cannot receive SMS messages
    line 165: * Message and data rates may apply
    line 190: this.flash = { error: "Your session has been interrupted, please start over" };
    line 200: this.flash = { error: "Please select a country code" };
    line 206: this.flash = { error: "Please provide a phone number" };
    line 241: this.flash = { success: "Phone number has been verified" };
    line 254: error: "Confirmation was attempted a moment ago. You can attempt verification again in one minute."
    line 315: Thank you for providing your phone number (
    line 317: ).
    line 320: To continue please enter the SMS code we've sent you.
    line 332: Confirmation code
    line 337: Didn't receive the verification code?{" "}
    line 350: const props = { body, title: "Phone Confirmation", assets, meta: [] };

    https://github.com/steemit/condenser/blob/master/src/server/utils/teleSign.js
    line 30: error: 'Unable to verify your phone number. Please try a different phone number.',
    line 46: return { error: 'Unable to verify phone, please try again later.' };

    https://github.com/steemit/condenser/blob/master/src/server/server-error.jsx
    line 10:

    Sorry.

    Looks like something went wrong on our end.

    Head back to Steemit homepage.

    @sneak sneak changed the title Fix hard-coded strings Fix hard-coded text strings that are not i18nized Jan 31, 2018
    @bnchdrff bnchdrff added the 3 label Feb 5, 2018
    @bnchdrff bnchdrff assigned bnchdrff and unassigned originated Feb 13, 2018
    @bnchdrff bnchdrff added 2 and removed 3 labels Feb 20, 2018
    @bnchdrff bnchdrff removed their assignment Feb 28, 2018
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    No branches or pull requests

    5 participants