Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support import statements #154

Closed
natew opened this issue Jul 10, 2017 · 2 comments
Closed

Support import statements #154

natew opened this issue Jul 10, 2017 · 2 comments

Comments

@natew
Copy link

natew commented Jul 10, 2017

Just tested this and it seems to fail (setting modules: false in babel-preset-env)
@steelbrain
Copy link
Owner

You shouldn't be setting modules to false in env preset. We'll have native support for imports when support for tree shaking lands until then use babel

@natew
Copy link
Author

natew commented Jul 10, 2017

Ok just was trying because react-hot-loader expects it to be false to work and I'm attempting to get hmr right finally, (see gaearon/react-hot-loader#565). We are close but a few bugs in that repo are holding back so am just exploring.

@natew natew closed this as completed Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@natew @steelbrain