feat: add blas/ext/base/sindex-of
#7318
Draft
+838
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
stdlib-bot
added
the
BLAS
headlessNode
added
Feature
Coverage Report
The above coverage report was generated for the changes in this PR. |
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
kgryte
changed the title
blas/ext/base/sindexofblas/ext/base/sindex-of
kgryte
reviewed
Jun 12, 2025
| var sindexOf = require( '@stdlib/blas/ext/base/sindex-of' ); | ||
| ``` | ||
|
|
||
| #### sindexOf( N, searchElement, x, strideX\[, offsetX ] ) |
There was a problem hiding this comment.
@headlessNode This is not correct. Our practice is to always have separate APIs. One for providing an offset and another in which the offset is computed. This follows BLAS conventions. I am not sure why you decided to make the API variadic.
kgryte
reviewed
Jun 12, 2025
| - **searchElement**: element to search the index of. | ||
| - **x**: input [`Float32Array`][@stdlib/array/float32]. | ||
| - **strideX**: index increment. | ||
| - **offsetX**: starting index (_optional_). |
There was a problem hiding this comment.
Incorrect. Please follow existing practice.
kgryte
reviewed
Jun 12, 2025
| @@ -0,0 +1,40 @@ | |||
|
|
|||
| {{alias}}( N, searchElement, x, strideX[, offsetX ] ) | |||
kgryte
reviewed
Jun 12, 2025
| * var idx = sindexOf( x.length, 2.0, x, 1 ); | ||
| * // returns 1 | ||
| */ | ||
| declare function sindexOf( N: number, searchElement: number, x: Float32Array, strideX: number, offsetX?: number ): number; |
kgryte
reviewed
Jun 12, 2025
| * ## Notes | ||
| * | ||
| * - If unable to find an element which equals a provided search element, the function returns `-1`. | ||
| * - If `offsetX` is less than zero, the starting index is resolved relative to the last array element, with the last array element corresponding to `offsetX = -1`. |
There was a problem hiding this comment.
Offsets are never negative. Why are you designing the API this way? Please show me what BLAS package supports this behavior.
kgryte
reviewed
Jun 12, 2025
| * @param {Number} searchElement - number to search index of | ||
| * @param {Float32Array} x - input array | ||
| * @param {integer} strideX - index increment | ||
| * @param {NonNegativeInteger} [offsetX] - starting index |
There was a problem hiding this comment.
NonNegativeInteger directly contradicts what you stated in the index.d.ts file.
kgryte
reviewed
Jun 12, 2025
| return -1; | ||
| } | ||
|
|
||
| if ( offsetX === void 0 ) { |
kgryte
reviewed
Jun 12, 2025
|
|
||
| if ( offsetX === void 0 ) { | ||
| if ( strideX < 0 ) { | ||
| ix = x.length - 1; |
There was a problem hiding this comment.
We should NOT be assuming or inquiring anything about x length. Plus, this doesn't make sense at all. N and stride completely specify the array view defining what values are indexed.
kgryte
added
the
Needs Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Progresses #2656 .
Description
This pull request:
blas/ext/base/sindexofRelated Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers