-
-
Notifications
You must be signed in to change notification settings - Fork 813
bench: refactor random number generation in JS benchmarks for stats/base/dists/pareto-type1
#5260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ase/dists/pareto-type1
Coverage Report
The above coverage report was generated for the changes in this PR. |
@anandkaranubc ready for review |
@Planeshifter @kgryte please review this PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more changes are required. The rest looks good!
lib/node_modules/@stdlib/stats/base/dists/pareto-type1/cdf/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/pareto-type1/ctor/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/pareto-type1/mode/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/pareto-type1/pdf/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/pareto-type1/skewness/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
@anandkaranubc please review |
stats/base/dists/pareto-type1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks ready to be merged. Thanks for your work on this! Now, you can wait for a maintainer to merge it.
PR Commit Message
Please review the above commit message and make any necessary adjustments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gkbishnoi07 for your contribution and @anandkaranubc for review! Landing...
Resolves #4982
Description
What is the purpose of this pull request?
This pull request:
stats/base/dists/pareto-type1
.randu()
withuniform()
for cleaner and more consistent code.Related Issues
Does this pull request have any related issues?
This pull request:
stats/base/dists/pareto-type1
#4982Questions
Any questions for reviewers of this pull request?
No.
Other
Any other information relevant to this pull request?
No.
Checklist
Please ensure the following tasks are completed before submitting this pull request.