Skip to content

refactor: update blas/ext/base/dsort2sh to follow project conventions #3057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

hkcc375
Copy link

@hkcc375 hkcc375 commented Nov 2, 2024

Resolves #1497

Description

What is the purpose of this pull request?

This pull request:

  • refactors dsort2sh to follow project conventions.

Related Issues

Does this pull request have any related issues?

No

Questions

Any questions for reviewers of this pull request?

No

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Nov 2, 2024
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@hkcc375 hkcc375 requested a review from stdlib-bot November 2, 2024 14:13
@hkcc375 hkcc375 closed this Nov 2, 2024
@hkcc375 hkcc375 reopened this Nov 2, 2024
@hkcc375
Copy link
Author

hkcc375 commented Nov 2, 2024

Hey @Planeshifter @kgryte.
Can you please review the changes that I have made ?

@kgryte kgryte changed the title Refactor blas/ext/base/dsort2sh to follow project conventions refactor: update blas/ext/base/dsort2sh to follow project conventions Nov 18, 2024
@kgryte
Copy link
Member

kgryte commented Nov 18, 2024

/stdlib merge

@kgryte kgryte removed the request for review from stdlib-bot November 18, 2024 04:29
@kgryte kgryte added the Needs Review A pull request which needs code review. label Nov 18, 2024
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dsort2sh $\color{green}543/543$
$\color{green}+100.00\%$
$\color{green}53/53$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}543/543$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/dsort2sh to follow current project conventions
4 participants