feat: add lapack/base/dpoequ
#2785
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pranavchiku
added
Feature
kgryte
reviewed
Sep 17, 2024
| smin = S[ offsetS ]; | ||
| amax[ offsetAM ] = S[ offsetS ]; | ||
| for ( i = 1; i < N; i++ ) { | ||
| S[ offsetS + ( i * strideS ) ] = A[ offsetA + ( i * strideA1 ) + ( i * strideA2 ) ]; |
There was a problem hiding this comment.
Same comments, as elsewhere, regarding unnecessary flops.
kgryte
reviewed
Sep 17, 2024
| t.end(); | ||
| }); | ||
|
|
||
| tape( 'the function supports accessing elements from non-contiguous arrangement of rows and columns and in different order', function test( t ) { |
There was a problem hiding this comment.
@Pranavchiku You need to provide more systematic and thorough tests, similar to what is common practice for existing BLAS and LAPACK routines in stdlib.
kgryte
added
Needs Review
kgryte
reviewed
Jan 28, 2025
|
|
||
| return benchmark; | ||
|
|
||
| function benchmark( b ) { |
kgryte
reviewed
Jan 28, 2025
|
|
||
| The function has the following parameters: | ||
|
|
||
| - **N**: order of matrix. |
There was a problem hiding this comment.
Or I suppose by "order", you mean the number of elements along each dimension of a square matrix A.
kgryte
reviewed
Jan 28, 2025
| * Computes row and column scalings intended to equilibrate a symmetric positive definite matrix `A`. | ||
| * | ||
| * @private | ||
| * @param {NonNegativeInteger} N - order of matrix |
There was a problem hiding this comment.
Should change the description from order of matrix to the more descriptive "number of elements along each dimension of A".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2464.
Description
This pull request adds JS implementation for
lapack/base/dpoequ.Related Issues
NA
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers