Skip to content

Conversation

@gunjjoshi
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@Planeshifter Planeshifter self-requested a review August 6, 2024 13:33
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label Aug 6, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine (being the single-precision variant of @stdlib/constants/float64/max-base2-exponent-subnormal.)

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Aug 6, 2024
@Planeshifter Planeshifter merged commit 130c7a5 into stdlib-js:develop Aug 6, 2024
@gunjjoshi gunjjoshi deleted the max-base2-exponent-subnormal branch August 7, 2024 05:15
gunjjoshi added a commit to gunjjoshi/stdlib that referenced this pull request Aug 21, 2024
PR-URL stdlib-js#2749
Ref: stdlib-js#649

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants