Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use int64_t, check last bit, cast to double in math/base/special/binomcoef #2733

Merged
merged 2 commits into from
Aug 3, 2024
Merged

refactor: use int64_t, check last bit, cast to double in math/base/special/binomcoef #2733

merged 2 commits into from
Aug 3, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Aug 3, 2024 •
edited
Loading

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Aug 3, 2024
@kgryte kgryte added the Needs Review A pull request which needs code review. label Aug 3, 2024
kgryte
kgryte approved these changes Aug 3, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @gunjjoshi!

@kgryte kgryte merged commit 5cd396f into stdlib-js:develop Aug 3, 2024
14 checks passed
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Aug 3, 2024
gunjjoshi added a commit to gunjjoshi/stdlib that referenced this pull request Aug 21, 2024
@gunjjoshi
refactor: use bitwise operation and make casting behavior explicit
2dc4c89 
PR-URL: stdlib-js#2733
Ref: stdlib-js@06b8011#r144990986
Ref: stdlib-js@06b8011#r144991031
Ref: stdlib-js@06b8011#r144991056
Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gunjjoshi @kgryte @stdlib-bot