Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add C implementation for math/base/special/powm1 #2660

Merged
merged 2 commits into from
Jul 28, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Jul 25, 2024

Description

What is the purpose of this pull request?

This pull request:

double stdlib_base_powm1( const double b, const double x );

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

I've checked the implementation with the latest boost implementation, and have made some changes.

Older version: https://www.boost.org/doc/libs/1_60_0/boost/math/special_functions/powm1.hpp
Latest version: https://www.boost.org/doc/libs/1_85_0/boost/math/special_functions/powm1.hpp

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Jul 25, 2024
@Planeshifter Planeshifter self-requested a review July 26, 2024 13:08
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label Jul 26, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Jul 28, 2024
@Planeshifter Planeshifter merged commit 62e247d into stdlib-js:develop Jul 28, 2024
8 checks passed
@gunjjoshi gunjjoshi deleted the powm1 branch July 29, 2024 03:57
gunjjoshi added a commit to gunjjoshi/stdlib that referenced this pull request Aug 21, 2024
PR-URL: stdlib-js#2660
Ref: stdlib-js#649

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants