Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add C implementation for math/base/special/factorial #2618

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Jul 17, 2024

Description

What is the purpose of this pull request?

This pull request:

double stdlib_base_factorial( const double x );

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Jul 17, 2024
@kgryte
Copy link
Member

kgryte commented Jul 17, 2024

@gunjjoshi We should amend the signature to be

double stdlib_base_factorial( const int32_t x );

Having double precision input in C doesn't make sense for this package.

@kgryte kgryte added C Issue involves or relates to C. Needs Changes Pull request which needs changes before being merged. Feature Issue or pull request for adding a new feature. labels Jul 17, 2024
@gunjjoshi
Copy link
Member Author

@gunjjoshi We should amend the signature to be

double stdlib_base_factorial( const int32_t x );

Having double precision input in C doesn't make sense for this package.

Sure, I'll update this.

@Planeshifter Planeshifter self-requested a review July 17, 2024 20:26
@gunjjoshi
Copy link
Member Author

@gunjjoshi We should amend the signature to be

double stdlib_base_factorial( const int32_t x );

Having double precision input in C doesn't make sense for this package.

@kgryte Wouldn't this lead to different behaviors in C and JavaScript? For instance, currently:

var v = factorial( 0.5 );
// returns ~0.886

But, in C, this won't be possible, as we will have only integers as input.

@kgryte
Copy link
Member

kgryte commented Jul 17, 2024

Ah wait. You're right. I forgot about the gamma approximation. Disregard my comment

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all well; will merge shortly.

@Planeshifter Planeshifter merged commit cc98b20 into stdlib-js:develop Jul 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants