Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update boost version in math/base/special/digamma #2577

Merged
merged 4 commits into from
Jul 13, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Jul 13, 2024

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

I checked out both the implementations, but couldn't find any change, instead of some documentation changes. The function digamma_imp(T x, const Tag* t, const Policy& pol) is the same in both of them.

I might be mistaken regarding this, but it would be great if you can also have a look at it once, if there are any significant changes, as boost implementations are quite confusing.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Jul 13, 2024
@kgryte kgryte requested a review from Planeshifter July 13, 2024 06:06
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gunjjoshi Thanks for double-checking the implementations. I believe you are correct and that there are indeed no applicable changes between the versions; I got confused too, it seems.

@Planeshifter Planeshifter merged commit ed638e3 into stdlib-js:develop Jul 13, 2024
7 checks passed
@gunjjoshi gunjjoshi deleted the digamma branch August 21, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Math Issue or pull request specific to math functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants