feat: add C implementation for math/base/special/roundb - #2544
Conversation
|
@gunjjoshi Would it make more sense to make |
Sure @kgryte, I will change that. |
|
@kgryte, Do we have Edit: checked it, we don't have this. |
|
Should I add |
|
@gunjjoshi Yes, that would be great! |
|
I believe you'll also need to add a corresponding macro to that same package. |
|
Yes. I'll add the macro in the |
|
@kgryte Our |
|
As discussed offline, the plan here is to remove non-applicable tests for the native bindings for |
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
|
I have also removed the checks in |
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
left a comment
There was a problem hiding this comment.
Thanks, @gunjjoshi! Will merge once CI passes.
Description
This pull request:
math/base/special/roundb.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers