Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add C implementation for math/base/special/digamma #2533

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Jul 7, 2024

Description

What is the purpose of this pull request?

This pull request:

double stdlib_base_digamma( const double x );

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Jul 7, 2024
@Planeshifter Planeshifter self-requested a review July 7, 2024 16:51
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks fine and matches what we have in JS. Thanks for the PR, @gunjjoshi!

However, it seems that the Boost reference implementation has changed.

Version this is derived from:
https://www.boost.org/doc/libs/1_53_0/boost/math/special_functions/digamma.hpp

Latest version:
https://www.boost.org/doc/libs/1_85_0/boost/math/special_functions/digamma.hpp

Would you mind looking into updating the implementation to track what is in Boost in a follow-up PR?

@Planeshifter Planeshifter merged commit 337adbf into stdlib-js:develop Jul 13, 2024
8 checks passed
@gunjjoshi
Copy link
Member Author

Yes @Planeshifter, I'll do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Math Issue or pull request specific to math functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants