Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add UX to cycle through completions in the REPL #2463

Merged
merged 27 commits into from
Jul 1, 2024
Merged

feat: add UX to cycle through completions in the REPL #2463

merged 27 commits into from
Jul 1, 2024

Commits on Jun 26, 2024

  1. feat: add UX to cycle through completions 

    Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
    @Snehil-Shah
    Snehil-Shah committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    989e2b4 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Signed-off-by: Athan <kgryte@gmail.com>
    @kgryte
    kgryte committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    1d6ad40 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
    @Snehil-Shah @kgryte
    Snehil-Shah and kgryte committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    e8e0e9f View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. fix: avoid navigating hidden completions 

    Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
    @Snehil-Shah
    Snehil-Shah committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    535986f View commit details
    Browse the repository at this point in the history

  2. refactor: use \n instead of \r\n 

    Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
    @Snehil-Shah
    Snehil-Shah committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    4babb98 View commit details
    Browse the repository at this point in the history

  3. fix: abnormal behavior with ENTER 

    Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
    @Snehil-Shah
    Snehil-Shah committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    755ddee View commit details
    Browse the repository at this point in the history

  4. fix: duplicate line events 

    Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
    @Snehil-Shah
    Snehil-Shah committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    2fcb356 View commit details
    Browse the repository at this point in the history

  5. fix: incorrect height 

    Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
    @Snehil-Shah
    Snehil-Shah committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    9de549d View commit details
    Browse the repository at this point in the history

  6. fix: bug with ENTER 

    Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
    @Snehil-Shah
    Snehil-Shah committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    2b1f666 View commit details
    Browse the repository at this point in the history

  7. test: add test case 

    Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
    @Snehil-Shah
    Snehil-Shah committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    7510ba9 View commit details
    Browse the repository at this point in the history

  8. test: fix brittle test cases 

    Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
    @Snehil-Shah
    Snehil-Shah committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    da8f7ee View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2024

  1. feat: allow sustaining the completions panel 

    Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
    @Snehil-Shah
    Snehil-Shah committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    63ce461 View commit details
    Browse the repository at this point in the history

  2. fix: reorder keypress handlers according to precedence 

    Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
    @Snehil-Shah
    Snehil-Shah committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    d4afb81 View commit details
    Browse the repository at this point in the history

  3. fix: make it receptive to SIGINT events 

    Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
    @Snehil-Shah
    Snehil-Shah committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    858eddb View commit details
    Browse the repository at this point in the history

  4. fix: reorder keypress handlers according to precedence 

    Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
    @Snehil-Shah
    Snehil-Shah committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    6fd48a8 View commit details
    Browse the repository at this point in the history

  5. feat: allow navigating the line when navigating 

    Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
    @Snehil-Shah
    Snehil-Shah committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    5bb319c View commit details
    Browse the repository at this point in the history

  6. refactor: clean logic and avoid unnecessary re-rendering 

    Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
    @Snehil-Shah
    Snehil-Shah committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    7f4eac7 View commit details
    Browse the repository at this point in the history

  7. test: remove outdated test 

    Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
    @Snehil-Shah
    Snehil-Shah committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    ddcd3d6 View commit details
    Browse the repository at this point in the history

  8. fix: don't close when completer is already closed 

    Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
    @Snehil-Shah
    Snehil-Shah committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    494f845 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2024

  1. test: add test case for live completions 

    Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
    @Snehil-Shah
    Snehil-Shah committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    141bfe4 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. fix: incorrect logic 

    Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
    @Snehil-Shah
    Snehil-Shah committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    5410b2b View commit details
    Browse the repository at this point in the history

  2. fix: incorrect keypress handlers 

    Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
    @Snehil-Shah
    Snehil-Shah committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    3677b2a View commit details
    Browse the repository at this point in the history

  3. test: update test names 

    Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
    @Snehil-Shah
    Snehil-Shah committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    e53f691 View commit details
    Browse the repository at this point in the history

  4. docs: fix jsdoc 

    Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
    @Snehil-Shah
    Snehil-Shah committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    4b8a752 View commit details
    Browse the repository at this point in the history

  5. fix: update after inserting a completion 

    Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
    @Snehil-Shah
    Snehil-Shah committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    71b5c4c View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Signed-off-by: Athan <kgryte@gmail.com>
    @kgryte
    kgryte committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    e862980 View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review 

    Signed-off-by: Athan <kgryte@gmail.com>
    @kgryte
    kgryte committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    97329bf View commit details
    Browse the repository at this point in the history