Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add C implementation for math/base/special/tan #2368

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Jun 13, 2024

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for math/base/special/tan.
  • uses constants from packages in both javascript and C implementations, rather than defining them explicitly.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Jun 13, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation matches reference one from FreeBSD and everything else checks out, so this should be ready to land. I have only one request concerning reverting a change in the variable names inside the JS code.

Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@Planeshifter Planeshifter merged commit 6199f14 into stdlib-js:develop Jun 14, 2024
8 checks passed
@gunjjoshi gunjjoshi deleted the tan branch June 20, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Math Issue or pull request specific to math functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants