Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add blas/base/zcopy #2064

Merged
merged 9 commits into from
Apr 3, 2024
Merged

feat: add blas/base/zcopy #2064

merged 9 commits into from
Apr 3, 2024

Conversation

aman-095
Copy link
Member

Description

What is the purpose of this pull request?

This RFC proposes to add a routine to copy values from one complex double-precision floating-point vector to another complex double-precision floating-point vector as defined in BLAS Level 1 routines. Specifically adding @stdlib/blas/base/zcopy is proposed.

Related Issues

Does this pull request have any related issues?
None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 27, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @aman-095. This looks good apart from the realf and imagf usage. Once resolved, this should be ready for merge.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. labels Mar 27, 2024
@kgryte
Copy link
Member

kgryte commented Mar 27, 2024

@aman-095 Are you planning on adding the C and Fortran implementations in a follow-up PR? Or will you be adding them to this PR?

@aman-095
Copy link
Member Author

@kgryte I'll correct the implementation and yes I will add the C and Fortran implementation in this PR itself.

@kgryte
Copy link
Member

kgryte commented Mar 27, 2024

@aman-095 Great! Thanks!

Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @aman-095!

Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Apr 3, 2024
@kgryte kgryte merged commit 1dda7d2 into stdlib-js:develop Apr 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants