feat: add C implementation for math/base/special/fast/abs
#1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
|
Will have to discuss if this is needed and / or what can be suitable C API. |
Pranavchiku
added
Feature
kgryte
reviewed
Mar 16, 2024
kgryte
added
Needs Review
|
Adding a C implementation for the "fast" implementations is fine. Moving to "needs review". |
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Pranavchiku
approved these changes
Mar 16, 2024
There was a problem hiding this comment.
LGTM. Thanks @gunjjoshi !
@gunjjoshi please open an issue tracking C implementation for math/base/special/fast/*
Pranavchiku
added
Ready To Merge
Sure, I'll do that. |
14 tasks
Planeshifter
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a part of #1917 .
Description
This pull request:
math/base/special/fast/abs.Related Issues
This pull request:
math/base/special/fast/*(Tracking Issue) #1917.Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers