Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove invalid examples in native.js for @stdlib/math/base/special/fibonacci #1814

Merged
merged 2 commits into from
Mar 10, 2024
Merged

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Mar 10, 2024

Description

This PR removes invalid examples in native.js for @stdlib/math/base/special/fibonacci, which were the non-integer and NaN input examples, as suggested here.

What is the purpose of this pull request?

This pull request:

  • removes invalid examples in native.js for @stdlib/math/base/special/fibonacci.

Related Issues

Does this pull request have any related issues?

n/a

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I restored the negative integer example, as it is handled by the C implementation, as n can be an int32_t.

@kgryte kgryte added the Documentation Improvements, additions, or changes to documentation. label Mar 10, 2024
@gunjjoshi
Copy link
Member Author

LGTM. I restored the negative integer example, as it is handled by the C implementation, as n can be an int32_t.

Great, thanks for that.

@kgryte kgryte merged commit 5108869 into stdlib-js:develop Mar 10, 2024
5 checks passed
@gunjjoshi gunjjoshi deleted the fibonacci branch March 11, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements, additions, or changes to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants