-
-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add C implementation for math/base/assert/is-nonnegative-integer
#1746
Conversation
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
stdlib/math/base/assert/is-nonnegative-integer
math/base/assert/is-nonnegative-integer
lib/node_modules/@stdlib/math/base/assert/is-nonnegative-integer/src/addon.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/assert/is-nonnegative-integer/src/main.c
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @gunjjoshi. Left a couple of comments. Looks like we need to update math/base/napi/unary
OR you can manually handle the add-on interface. See, e.g., https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/math/base/assert/is-even/src/addon.c.
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
For now, I've manually handled the add-on interface. |
Hey @kgryte @Planeshifter, any other suggestions on this ? |
lib/node_modules/@stdlib/math/base/assert/is-nonnegative-integer/src/main.c
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @gunjjoshi!
Resolves #1723
Description
Added C implementation for
stdlib/math/base/assert/is-nonnegative-integer
.This pull request:
stdlib/math/base/assert/is-nonnegative-integer
Related Issues
This pull request:
@stdlib/math/base/assert/is-nonnegative-integer
#1723@stdlib/math/base/special/bernoulli
#1664Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers