-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add C implementation for @stdlib/math/base/special/min
#1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pranavchiku
requested changes
Mar 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes requested, this PR is good. Thank you volunteering this!
lib/node_modules/@stdlib/math/base/special/min/include/stdlib/math/base/special/min.h
Outdated
Show resolved
Hide resolved
Pranavchiku
added
the
Needs Changes
Pull request which needs changes before being merged.
label
Mar 2, 2024
Pranavchiku
added
Feature
Issue or pull request for adding a new feature.
C
Issue involves or relates to C.
labels
Mar 2, 2024
Pranavchiku
reviewed
Mar 2, 2024
Pranavchiku
reviewed
Mar 2, 2024
Pranavchiku
reviewed
Mar 2, 2024
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Pranavchiku
approved these changes
Mar 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works. Thank you for this PR!
Pranavchiku
added
Ready To Merge
A pull request which is ready to be merged.
and removed
Needs Changes
Pull request which needs changes before being merged.
labels
Mar 2, 2024
3 tasks
Pranavchiku
reviewed
Mar 2, 2024
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
utkrs01
pushed a commit
to utkrs01/stdlib
that referenced
this pull request
Mar 7, 2024
PR-URL: stdlib-js#1443 --------- Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com> Co-authored-by: Pranav <85227306+Pranavchiku@users.noreply.github.com> Reviewed-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C
Issue involves or relates to C.
Feature
Issue or pull request for adding a new feature.
Ready To Merge
A pull request which is ready to be merged.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves # .
Description
This pull request adds native C implementation for
@stdlib/math/base/special/min
. Looking at #1433 I thought this would be good to have.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers