Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C implementation for @stdlib/math/base/special/ahavercos #1419

Merged
merged 10 commits into from
Mar 1, 2024

Conversation

aman-095
Copy link
Member

@aman-095 aman-095 commented Feb 29, 2024

Resolves #1418.

Description

What is the purpose of this pull request?

This pull request adds native C implementation for @stdlib/math/base/special/ahavercos

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, address requested changes and this will be good to merge. Thanks @aman-095 !

Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for your contribution!

@Pranavchiku Pranavchiku added the Ready To Merge A pull request which is ready to be merged. label Mar 1, 2024
@Planeshifter Planeshifter merged commit eace8f3 into stdlib-js:develop Mar 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/math/base/special/ahavercos
4 participants