Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: add math/base/special/fmod #2405

Closed
3 tasks done
gunjjoshi opened this issue Jun 19, 2024 · 2 comments · Fixed by #2562
Closed
3 tasks done

[RFC]: add math/base/special/fmod #2405

gunjjoshi opened this issue Jun 19, 2024 · 2 comments · Fixed by #2562
Assignees
@gunjjoshi
Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 3 Likely to be challenging but manageable. Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. Math Issue or pull request specific to math functionality. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.

Comments

@gunjjoshi
Copy link
Member

Description

This RFC proposes adding math/base/special/fmod, which would follow this reference implementation: https://github.com/JuliaMath/openlibm/blob/master/src/e_fmod.c

This would enable us to have a function that works the same way as the modulus operator in javascript does.

Related Issues

None.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first issue! We will get back to you shortly. 🏃 💨

@kgryte kgryte added RFC Request for comments. Feature requests and proposed changes. Feature Issue or pull request for adding a new feature. difficulty: 3 Likely to be challenging but manageable. Math Issue or pull request specific to math functionality. Accepted RFC feature request which has been accepted. priority: Normal Normal priority concern or feature request. C Issue involves or relates to C. JavaScript Issue involves or relates to JavaScript. labels Jun 19, 2024
@kgryte
Copy link
Member

kgryte commented Jun 19, 2024

Thanks, @gunjjoshi! This sounds good and would be a good addition.

@gunjjoshi gunjjoshi mentioned this issue Jul 11, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gunjjoshi gunjjoshi

Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 3 Likely to be challenging but manageable. Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. Math Issue or pull request specific to math functionality. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add math/base/special/fmod gunjjoshi/stdlib
3 participants
@kgryte @gunjjoshi @stdlib-bot