Skip to content

Commit 8ce04f0

Browse files
committed
fix: correct FLOAT32_MAX_SAFE_NTH_DOUBLE_FACTORIAL
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent ba45bb5 commit 8ce04f0

File tree

7 files changed

+15
-13
lines changed

7 files changed

+15
-13
lines changed

lib/node_modules/@stdlib/constants/float32/max-safe-nth-double-factorial/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ The maximum [safe][safe-integers] nth [double factorial][double-factorial] when
3939
<!-- eslint-disable id-length -->
4040

4141
```javascript
42-
var bool = ( FLOAT32_MAX_SAFE_NTH_DOUBLE_FACTORIAL === 56 );
42+
var bool = ( FLOAT32_MAX_SAFE_NTH_DOUBLE_FACTORIAL === 16 );
4343
// returns true
4444
```
4545

@@ -71,7 +71,7 @@ function factorial2( n ) {
7171

7272
var v;
7373
var i;
74-
for ( i = 0; i < 100; i++ ) {
74+
for ( i = 0; i < 25; i++ ) {
7575
v = factorial2( i );
7676
if ( i > FLOAT32_MAX_SAFE_NTH_DOUBLE_FACTORIAL ) {
7777
console.log( 'Unsafe: %d', v );

lib/node_modules/@stdlib/constants/float32/max-safe-nth-double-factorial/docs/repl.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
Examples
77
--------
88
> {{alias}}
9-
56
9+
16
1010

1111
See Also
1212
--------

lib/node_modules/@stdlib/constants/float32/max-safe-nth-double-factorial/docs/types/index.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
*
2424
* @example
2525
* var max = FLOAT32_MAX_SAFE_NTH_DOUBLE_FACTORIAL;
26-
* // returns 56
26+
* // returns 16
2727
*/
2828
declare const FLOAT32_MAX_SAFE_NTH_DOUBLE_FACTORIAL: number;
2929

lib/node_modules/@stdlib/constants/float32/max-safe-nth-double-factorial/examples/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ function factorial2( n ) {
3333

3434
var v;
3535
var i;
36-
for ( i = 0; i < 100; i++ ) {
36+
for ( i = 0; i < 25; i++ ) {
3737
v = factorial2( i );
3838
if ( i > FLOAT32_MAX_SAFE_NTH_DOUBLE_FACTORIAL ) {
3939
console.log( 'Unsafe: %d', v );

lib/node_modules/@stdlib/constants/float32/max-safe-nth-double-factorial/include/stdlib/constants/float32/max_safe_nth_double_factorial.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@
1616
* limitations under the License.
1717
*/
1818

19-
#ifndef STDLIB_CONSTANTS_FLOAT32_MAX_SAFE_NTH_DOUBLE_FACTORIAL
20-
#define STDLIB_CONSTANTS_FLOAT32_MAX_SAFE_NTH_DOUBLE_FACTORIAL
19+
#ifndef STDLIB_CONSTANTS_FLOAT32_MAX_SAFE_NTH_DOUBLE_FACTORIAL_H
20+
#define STDLIB_CONSTANTS_FLOAT32_MAX_SAFE_NTH_DOUBLE_FACTORIAL_H
2121

2222
/**
2323
* Macro for the maximum safe nth double factorial when stored in single-precision floating-point format.
2424
*/
25-
#define STDLIB_CONSTANT_FLOAT32_MAX_SAFE_NTH_DOUBLE_FACTORIAL 56
25+
#define STDLIB_CONSTANT_FLOAT32_MAX_SAFE_NTH_DOUBLE_FACTORIAL 16
2626

2727
#endif // !STDLIB_CONSTANTS_FLOAT32_MAX_SAFE_NTH_DOUBLE_FACTORIAL_H

lib/node_modules/@stdlib/constants/float32/max-safe-nth-double-factorial/lib/index.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616
* limitations under the License.
1717
*/
1818

19+
/* eslint-disable id-length */
20+
1921
'use strict';
2022

2123
/**
@@ -26,7 +28,7 @@
2628
*
2729
* @example
2830
* var FLOAT32_MAX_SAFE_NTH_DOUBLE_FACTORIAL = require( '@stdlib/constants/float32/max-safe-nth-double-factorial' );
29-
* // returns 56
31+
* // returns 16
3032
*/
3133

3234

@@ -37,11 +39,11 @@
3739
*
3840
* @constant
3941
* @type {integer}
40-
* @default 56
42+
* @default 16
4143
* @see [double factorial]{@link https://en.wikipedia.org/wiki/Double_factorial}
4244
* @see [IEEE 754]{@link https://en.wikipedia.org/wiki/IEEE_754-1985}
4345
*/
44-
var FLOAT32_MAX_SAFE_NTH_DOUBLE_FACTORIAL = 56|0; // eslint-disable-line id-length
46+
var FLOAT32_MAX_SAFE_NTH_DOUBLE_FACTORIAL = 16|0; // asm type annotation
4547

4648

4749
// EXPORTS //

lib/node_modules/@stdlib/constants/float32/max-safe-nth-double-factorial/test/test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ tape( 'main export is a number', function test( t ) {
3232
t.end();
3333
});
3434

35-
tape( 'the exported value is 56', function test( t ) {
36-
t.strictEqual( FLOAT32_MAX_SAFE_NTH_DOUBLE_FACTORIAL, 56, 'returns expected value' );
35+
tape( 'the exported value is 16', function test( t ) {
36+
t.strictEqual( FLOAT32_MAX_SAFE_NTH_DOUBLE_FACTORIAL, 16, 'returns expected value' );
3737
t.end();
3838
});

0 commit comments

Comments
 (0)