Add response content to ApiException class #83
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a response field to the staxapp.exceptions.ApiException class, this allows users to use the response even in error scenarios, an example might be when creating an account type that already exists the API returns HTTP/400 which the SDK raises an exception for, however the api returns the details about the existing account-type but doesn't pass them back to the calling code.
example
this means the user needs to make another get call just to get the existing ID
the response data (json or otherwise) is logged but not stored meaning users need to make a second call or attempt to string parse the logs 🙅
no - this only adds a new attribute to an existing class