Skip to content

feat(sdk): remove pycrypto and general package cleanup #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 30, 2020

Conversation

Anton0
Copy link
Contributor

@Anton0 Anton0 commented Nov 30, 2020

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

  • install pycrypto (in setup.py and requirements.txt)
  • requirements.txt is both dev deps and a duplicate of setup.py

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • no - if anything it reduces the number of packages users will be pulling down.

@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

Merging #61 (02694ef) into master (086b52c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #61   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          329       329           
=========================================
  Hits           329       329           

@Anton0 Anton0 changed the title Feat remove redundant packages feat(sdk): remove pycrypto and general package cleanup Nov 30, 2020
@Anton0 Anton0 marked this pull request as ready for review November 30, 2020 05:18
@Anton0 Anton0 requested a review from a team as a code owner November 30, 2020 05:18
@Anton0 Anton0 merged commit b409109 into stax-labs:master Nov 30, 2020
@Anton0 Anton0 mentioned this pull request Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants