Skip to content

fix(invalid_token): Retry cognito signed token issues #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2020

Conversation

Levence
Copy link
Contributor

@Levence Levence commented Aug 17, 2020

  • What kind of change does this PR introduce?
    Bug fix

  • What is the current behavior?
    There must be some eventual consistency issue with AWS and issuing a Cognito token, after issuing a new Cognito token when we call Cognito.get_id we occasionally receive a NotAuthorizedException with the message "Invalid login token. Couldn't verify signed token." Simply retrying the same call with the same token works without issue.

  • Does this PR introduce a breaking change?
    No breaking changes.

@Levence Levence requested a review from mat-lord August 17, 2020 01:39
@Levence Levence requested a review from a team as a code owner August 17, 2020 01:39
@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #57 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #57   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          323       329    +6     
=========================================
+ Hits           323       329    +6     
Impacted Files Coverage Δ
staxapp/auth.py 100.00% <100.00%> (ø)

@Levence Levence merged commit 54df36b into master Aug 17, 2020
@Levence Levence deleted the fix/signed-token-issue branch August 17, 2020 01:54
@Anton0 Anton0 mentioned this pull request Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants