Skip to content

refactor (sdk) refactor user agent to be string parseable #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 27, 2020

Conversation

ZXYmania
Copy link
Contributor

@ZXYmania ZXYmania commented Jul 28, 2020

Refactor the user agent string to be easily parseable

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

@ZXYmania ZXYmania force-pushed the refactor/user-agent branch from e63aac1 to 6b89457 Compare July 28, 2020 04:04
@Anton0 Anton0 self-requested a review August 28, 2020 00:42
@ZXYmania ZXYmania marked this pull request as ready for review October 26, 2020 23:27
@ZXYmania ZXYmania requested a review from a team as a code owner October 26, 2020 23:27
@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #55 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #55   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          329       329           
=========================================
  Hits           329       329           
Impacted Files Coverage Δ
staxapp/api.py 100.00% <ø> (ø)
staxapp/config.py 100.00% <100.00%> (ø)

@Anton0 Anton0 mentioned this pull request Oct 27, 2020
@ZXYmania ZXYmania merged commit ef5f3cc into master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants