Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use storage_dir key in config for default storage directory #210

Merged
merged 1 commit into from
Jan 8, 2018

Conversation

mayppong
Copy link

@mayppong mayppong commented Aug 2, 2017

Allow users to specify default directory in the config file for arc.

Allow users to specify default path in the config file for arc
@igorbelo
Copy link

igorbelo commented Sep 26, 2017

It's unnecessary since you can override the storage_dir/2 function in your definition file.

@pedep
Copy link
Contributor

pedep commented Jan 4, 2018

While i agree with @igorbelo, that you most likely will need to overwrite storage_dir in the individual definition, i see no reason we can't merge this. Are there any drawbacks?
Since its only a 1 line change, i doubt this will increase complexity. So unless a change like this will impact performance noticably, it LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants