-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failed faceid clears auth settings #9882
Conversation
Pull Request Checklist
|
4663f3c
to
43633af
Compare
Jenkins BuildsClick to see older builds (3)
|
by @simonricoo
|
278c3bb
to
c8f2a94
Compare
Looks good to me with iOS (FaceID) and Samsung S8 (TouchID) for the:
but from #9871 what's left is : VS If I enabled FaceID and re-open app, or login in to account from login page via tap on biometric icon next to password field (when FaceID failed) bio check happens on blank screen. @Ferossgp could we |
➤ Sergey Chumak commented: Looks good to me with iOS (FaceID) and Samsung S8 (TouchID) for the:
but from #9871 what's left is : VS https://user-images.githubusercontent.com/8749671/73858745-90584700-4841-11ea-816d-53db11fdad79.png If I enabled FaceID and re-open app, or login in to account from login page via tap on biometric icon next to password field (when FaceID failed) bio check happens on blank screen. @Ferossgp could we |
@Serhy the background is hidden because you have enabled "Hide Status previews when app switching" in Privacy and security. The face-id popup is a native app, which is opened above the Status app and changes the focus. |
Don't have phone with FaceID now, so will wait for @Serhy |
@Ferossgp you are correct. |
Do not change auth method if user does not save password Sanity check - fix only for biometric method Check for new auth method only when save password ScrollView Persist taps on login view Signed-off-by: Gheorghe Pinzaru <feross95@gmail.com>
c8f2a94
to
ff1022f
Compare
Fixes #9871