fix: set max option not work when send from qrcode #13733

yqrashawn · 2022-07-28T10:41:12Z

Summary

The bug is caused by lack of [:wallet/prepare-transaction :gasPrice] in db
code at: https://github.com/status-im/status-mobile/blob/7a97d88983cce567b781619ad379cf96227d1ecf/src/status_im/wallet/core.cljs#L390-L395

which is caused by these two functions https://github.com/status-im/status-mobile/blob/7a97d88983cce567b781619ad379cf96227d1ecf/src/status_im/wallet/choose_recipient/core.cljs#L54-L104

fill-prepare-transaction-details is used to fill :wallet/prepare-transaction based on details parse from URI (parsed from qr code here)
which won't fill :gasPrice if it's not presented in qr code

the solution here is to return :signing/update-gas-price fx if there's no [:wallet/prepare-transaction :gasPrice] in the result of fill-prepare-transaction-details

Platforms

Android
iOS

Areas that maybe impacted

logic related to eip-681 or this function https://github.com/status-im/status-mobile/blob/7a97d88983cce567b781619ad379cf96227d1ecf/src/status_im/wallet/choose_recipient/core.cljs#L113

Steps to test

Open Status
Using "Universal QR scanner" scan valid wallet address
Try to "Set max"

status: ready

yqrashawn · 2022-07-28T10:49:12Z

before:

CleanShot.2022-07-28.at.18.46.14.mp4

after:

CleanShot.2022-07-28.at.18.47.00.mp4

status-im-auto · 2022-07-28T10:51:04Z

Jenkins Builds

Click to see older builds (9)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`398d8ba`	#1	2022-07-28 10:51:03	~9 min	`android-e2e`	📦`apk` 📲
✔️	`398d8ba`	#1	2022-07-28 10:51:16	~9 min	`android`	📦`apk` 📲
✔️	`398d8ba`	#1	2022-07-28 10:53:37	~12 min	`ios`	📦`ipa` 📲

✔️	`ebd30a7`	#2	2022-07-28 13:41:54	~9 min	`android`	📦`apk` 📲
✔️	`ebd30a7`	#2	2022-07-28 13:44:13	~11 min	`android-e2e`	📦`apk` 📲
✔️	`ebd30a7`	#2	2022-07-28 13:45:43	~13 min	`ios`	📦`ipa` 📲

✔️	`77bef25`	#4	2022-08-01 10:08:30	~9 min	`android-e2e`	📦`apk` 📲
✔️	`77bef25`	#4	2022-08-01 10:08:35	~9 min	`android`	📦`apk` 📲
✔️	`77bef25`	#4	2022-08-01 10:09:36	~10 min	`ios`	📦`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`fe1a347`	#5	2022-08-02 10:24:51	~12 min	`android`	📦`apk` 📲
✔️	`fe1a347`	#5	2022-08-02 10:28:07	~15 min	`ios`	📦`ipa` 📲

✔️	`63147c4`	#6	2022-08-02 12:11:48	~12 min	`android`	📦`apk` 📲
✔️	`63147c4`	#6	2022-08-02 12:13:24	~13 min	`ios`	📦`ipa` 📲
✔️	`63147c4`	#7	2022-08-02 13:16:17	~10 min	`android-e2e`	📦`apk` 📲

yqrashawn · 2022-07-28T11:29:44Z

And although there are no keys like maxPriorityFeePerGas in eip-681
we might need to get them handled

shadow-cljs.edn

src/status_im/wallet/choose_recipient/core.cljs

flexsurfer

thank you

status-im-auto · 2022-08-02T10:52:49Z

97% of end-end tests have passed

Total executed tests: 87
Failed tests: 3
Passed tests: 84

IDs of failed tests: 700764,5315,702189

Failed tests (3)

Click to expand

Rerun failed tests

Class TestOneToOneChatMultipleSharedDevices:

1. test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks, id: 5315
Device 1: Find `ChatElementByText` by `xpath`: `//[starts-with(@text,'® æ ç ♥')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` Device 1: Find `Button` by `xpath`: `//[@text="Today"]` `critical/chats/test_1_1_public_chats.py:408: in test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks [chat.verify_message_is_under_today_text(timestamp_message, self.errors) for chat in (self.chat_1, self.c` Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestSendTxDeviceMerged:

1. test_send_tx_token_8_decimals, id: 700764
Device 1: Find `WalletButton` by `xpath`: `//[contains(@content-desc,'tab, 3 out of 5')]` Device 1: Find `WalletButton` by `xpath`: `//[contains(@content-desc,'tab, 3 out of 5')]` `critical/wallet_and_tx/test_send_tx_dapp_keycard.py:53: in test_send_tx_token_8_decimals self.network_api.find_transaction_by_hash(transaction_adi) ../support/api/network_api.py:76: in find_transaction_by_hash transaction = w3.transaction_status(t` Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs Failure screenshot

Class TestRestoreOneDeviceMerged:

1. test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx, id: 702189
Device 1: SilentButton element not found Device 1: Enter default pin 111111 `critical/onboarding/test_onboarding_flows.py:478: in test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx wallet.send_transaction(amount=transaction_amount_added, recipient=transaction_senders['ETH_8']['address'], ../vie` Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs Failure screenshot

Passed tests (84)

Click to expand

Class TestPublicChatBrowserOneDeviceMerged:

1. test_public_chat_open_using_deep_link, id: 700739
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
2. test_browser_bookmarks_create_edit_remove, id: 702077
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
3. test_browser_blocked_url, id: 702072
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
4. test_browser_delete_close_tabs, id: 702076
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
5. test_browser_connection_is_secure_not_secure_warning, id: 702073
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
6. test_browser_web3_permissions_testdapp, id: 702078
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
7. test_public_chat_tag_message, id: 700738
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
8. test_public_chat_navigate_to_chat_when_relaunch, id: 5396
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
9. test_public_chat_copy_and_paste_message_in_chat_input, id: 5317
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
10. test_public_chat_fetch_more_history, id: 5675
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
11. test_browser_offline, id: 702075
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
12. test_browser_invalid_url, id: 702074
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestSendTxDeviceMerged:

1. test_send_tx_eth_check_logcat, id: 700763
Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs
2. test_send_tx_custom_token_18_decimals_invalid_password, id: 700765
Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs
3. test_send_tx_set_recipient_options, id: 700757
Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs
4. test_send_tx_sign_message_2tx_in_batch_tx_filters_request_stt_testdapp, id: 5342
Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestPairingSyncMultipleDevicesMerged:

1. test_pairing_sync_clear_history, id: 702394
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_pairing_sync_contacts_block_unblock, id: 702196
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_pairing_sync_initial_profile_picture, id: 702392
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_pairing_sync_initial_bookmarks, id: 702393
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_pairing_sync_initial_contacts_blocked_users, id: 702194
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_pairing_sync_1_1_chat_message, id: 702198
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_pairing_sync_public_chat_add_remove, id: 702199
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_pairing_sync_initial_public_chats, id: 702195
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_pairing_sync_contacts_add_remove_set_nickname_ens, id: 702197
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestWalletManagementDeviceMerged:

1. test_wallet_manage_assets, id: 700758
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
2. test_wallet_add_account_seed_phrase_validation, id: 700762
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
3. test_wallet_add_hide_unhide_account_private_key, id: 700761
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
4. test_wallet_add_delete_watch_only_account, id: 700760
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
5. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
6. test_wallet_add_account_generate_new, id: 700759
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
7. test_wallet_tx_history_copy_tx_hash_on_cellular, id: 700756
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestOnboardingOneDeviceMerged:

1. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
2. test_onboarding_home_initial_popup, id: 700742
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
3. test_onboarding_share_contact_address, id: 700743
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
4. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
5. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
6. test_onboarding_share_wallet_address, id: 700744
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestPublicChatMultipleDeviceMerged:

1. test_public_chat_message_edit, id: 700734
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_public_chat_unread_messages_counter, id: 5360
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_public_chat_emoji_send_copy_paste_reply, id: 700719
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_public_chat_unread_messages_counter_for_mention_relogin, id: 700718
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_public_chat_delete_chat_long_press, id: 5319
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_public_chat_link_send_open, id: 700736
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_public_chat_mark_all_messages_as_read, id: 6270
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_public_chat_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_public_chat_message_send_check_timestamps_while_on_different_tab, id: 5313
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_public_chat_message_delete, id: 700735
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestKeycardTxOneDeviceMerged:

1. test_keycard_relogin_after_restore, id: 700768
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
2. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
3. test_keycard_create_account_unlock_same_seed, id: 5689
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
4. test_keycard_send_tx_eth, id: 700767
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
5. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestContactBlockMigrateKeycardMultipleSharedDevices:

1. test_contact_block_unblock_public_chat_offline, id: 702176
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_contact_add_remove_mention_default_username_nickname_public_chat, id: 702175
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_keycard_command_send_tx_eth_1_1_chat, id: 702186
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_restore_account_migrate_multiaccount_to_keycard_db_saved, id: 702177
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_cellular_settings_on_off_public_chat_fetching_history, id: 702188
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevices:

1. test_1_1_chat_text_message_edit_delete_push_disappear, id: 695843
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_message_reaction, id: 6315
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_emoji_send_reply_and_open_link, id: 5373
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_image_send_save_reply, id: 6305
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 5310
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_text_message_with_push, id: 6316
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_delete_via_delete_button_relogin, id: 5387
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_push_emoji, id: 6283
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMerged:

1. test_group_chat_push_system_messages_when_invited, id: 3994
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_highligted, id: 5756
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_join_send_text_messages_push, id: 700731
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_offline_pn, id: 3998
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
5. test_group_chat_add_new_member_activity_centre, id: 700732
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
6. test_group_chat_leave_relogin, id: 3997
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestEnsStickersMultipleDevicesMerged:

1. test_sticker_1_1_public_chat_mainnet, id: 702157
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_ens_command_send_tx_eth_1_1_chat, id: 702153
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_ens_mention_push_highlighted_public_chat, id: 702156
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_ens_mention_nickname_1_1_chat, id: 702155
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_ens_purchased_in_profile, id: 702152
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_start_new_chat_public_key_validation, id: 702158
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestRestoreOneDeviceMerged:

1. test_restore_set_up_wallet_sign_phrase, id: 700749
Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs
2. test_restore_seed_phrase_field_validation, id: 700750
Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs
3. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748
Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestCommandsMultipleDevicesMerged:

1. test_1_1_chat_command_decline_eth_push_changing_state, id: 6265
Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline, id: 6263
Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_command_send_tx_eth_outgoing_tx_push, id: 6253
Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

status-im-auto · 2022-08-02T11:09:04Z

100% of end-end tests have passed

Total executed tests: 1
Failed tests: 0
Passed tests: 1

Passed tests (1)

Click to expand

Class TestSendTxDeviceMerged:

1. test_send_tx_token_8_decimals, id: 700764
Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs

resolve status-im#11460 Signed-off-by: yqrashawn <namy.19@gmail.com>

status-im-auto · 2022-08-02T15:06:56Z

97% of end-end tests have passed

Total executed tests: 87
Failed tests: 3
Passed tests: 84

IDs of failed tests: 702189,5315,702076

Failed tests (3)

Click to expand

Rerun failed tests

Class TestPublicChatBrowserOneDeviceMerged:

1. test_browser_delete_close_tabs, id: 702076
Device 1: Find `Button` by `xpath`: `//[contains(@text, 'bbc.com')]/../../../../[@content-desc='empty-tab']` Device 1: Tap on found: Button `critical/test_public_chat_browsing.py:423: in test_browser_delete_close_tabs web_page.element_by_text_part(urls['bbc.com']).wait_for_invisibility_of_element() ../views/base_element.py:144: in wait_for_invisibility_of_element raise TimeoutException` Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs Failure screenshot

Class TestRestoreOneDeviceMerged:

1. test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx, id: 702189
Device 1: SilentButton element not found Device 1: Enter default pin 111111 `critical/onboarding/test_onboarding_flows.py:478: in test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx wallet.send_transaction(amount=transaction_amount_added, recipient=transaction_senders['ETH_8']['address'], ../vie` Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs Failure screenshot

Class TestOneToOneChatMultipleSharedDevices:

1. test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks, id: 5315
Device 1: Find `ChatElementByText` by `xpath`: `//[starts-with(@text,'® æ ç ♥')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` Device 1: Find `Button` by `xpath`: `//[@text="Today"]` `critical/chats/test_1_1_public_chats.py:408: in test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks [chat.verify_message_is_under_today_text(timestamp_message, self.errors) for chat in (self.chat_1, self.c` Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Passed tests (84)

Click to expand

Class TestOneToOneChatMultipleSharedDevices:

1. test_1_1_chat_push_emoji, id: 6283
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_image_send_save_reply, id: 6305
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 5310
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_message_reaction, id: 6315
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_delete_via_delete_button_relogin, id: 5387
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_emoji_send_reply_and_open_link, id: 5373
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_text_message_edit_delete_push_disappear, id: 695843
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_text_message_with_push, id: 6316
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestPublicChatMultipleDeviceMerged:

1. test_public_chat_link_send_open, id: 700736
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_public_chat_message_delete, id: 700735
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_public_chat_unread_messages_counter, id: 5360
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_public_chat_unread_messages_counter_for_mention_relogin, id: 700718
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_public_chat_delete_chat_long_press, id: 5319
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_public_chat_message_send_check_timestamps_while_on_different_tab, id: 5313
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_public_chat_emoji_send_copy_paste_reply, id: 700719
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_public_chat_mark_all_messages_as_read, id: 6270
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_public_chat_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_public_chat_message_edit, id: 700734
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestEnsStickersMultipleDevicesMerged:

1. test_start_new_chat_public_key_validation, id: 702158
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_sticker_1_1_public_chat_mainnet, id: 702157
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_ens_command_send_tx_eth_1_1_chat, id: 702153
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_ens_mention_push_highlighted_public_chat, id: 702156
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_ens_mention_nickname_1_1_chat, id: 702155
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_ens_purchased_in_profile, id: 702152
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestPublicChatBrowserOneDeviceMerged:

1. test_browser_connection_is_secure_not_secure_warning, id: 702073
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
2. test_public_chat_copy_and_paste_message_in_chat_input, id: 5317
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
3. test_browser_invalid_url, id: 702074
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
4. test_browser_bookmarks_create_edit_remove, id: 702077
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
5. test_public_chat_tag_message, id: 700738
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
6. test_browser_offline, id: 702075
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
7. test_public_chat_navigate_to_chat_when_relaunch, id: 5396
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
8. test_public_chat_open_using_deep_link, id: 700739
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
9. test_browser_blocked_url, id: 702072
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
10. test_browser_web3_permissions_testdapp, id: 702078
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
11. test_public_chat_fetch_more_history, id: 5675
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestWalletManagementDeviceMerged:

1. test_wallet_add_account_generate_new, id: 700759
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
2. test_wallet_add_hide_unhide_account_private_key, id: 700761
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
3. test_wallet_add_delete_watch_only_account, id: 700760
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
4. test_wallet_tx_history_copy_tx_hash_on_cellular, id: 700756
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
5. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
6. test_wallet_add_account_seed_phrase_validation, id: 700762
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
7. test_wallet_manage_assets, id: 700758
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestSendTxDeviceMerged:

1. test_send_tx_custom_token_18_decimals_invalid_password, id: 700765
Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs
2. test_send_tx_token_8_decimals, id: 700764
Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs
3. test_send_tx_set_recipient_options, id: 700757
Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs
4. test_send_tx_eth_check_logcat, id: 700763
Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs
5. test_send_tx_sign_message_2tx_in_batch_tx_filters_request_stt_testdapp, id: 5342
Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestRestoreOneDeviceMerged:

1. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748
Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs
2. test_restore_set_up_wallet_sign_phrase, id: 700749
Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs
3. test_restore_seed_phrase_field_validation, id: 700750
Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestKeycardTxOneDeviceMerged:

1. test_keycard_send_tx_eth, id: 700767
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
2. test_keycard_create_account_unlock_same_seed, id: 5689
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
3. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
4. test_keycard_relogin_after_restore, id: 700768
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
5. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestCommandsMultipleDevicesMerged:

1. test_1_1_chat_command_send_tx_eth_outgoing_tx_push, id: 6253
Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_command_decline_eth_push_changing_state, id: 6265
Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline, id: 6263
Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestContactBlockMigrateKeycardMultipleSharedDevices:

1. test_keycard_command_send_tx_eth_1_1_chat, id: 702186
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_contact_block_unblock_public_chat_offline, id: 702176
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_contact_add_remove_mention_default_username_nickname_public_chat, id: 702175
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_cellular_settings_on_off_public_chat_fetching_history, id: 702188
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_restore_account_migrate_multiaccount_to_keycard_db_saved, id: 702177
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOnboardingOneDeviceMerged:

1. test_onboarding_share_contact_address, id: 700743
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
2. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
3. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
4. test_onboarding_share_wallet_address, id: 700744
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
5. test_onboarding_home_initial_popup, id: 700742
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
6. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestPairingSyncMultipleDevicesMerged:

1. test_pairing_sync_contacts_add_remove_set_nickname_ens, id: 702197
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_pairing_sync_clear_history, id: 702394
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_pairing_sync_initial_bookmarks, id: 702393
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_pairing_sync_initial_profile_picture, id: 702392
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_pairing_sync_contacts_block_unblock, id: 702196
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_pairing_sync_initial_contacts_blocked_users, id: 702194
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_pairing_sync_initial_public_chats, id: 702195
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_pairing_sync_public_chat_add_remove, id: 702199
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_pairing_sync_1_1_chat_message, id: 702198
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMerged:

1. test_group_chat_leave_relogin, id: 3997
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_highligted, id: 5756
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_push_system_messages_when_invited, id: 3994
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_join_send_text_messages_push, id: 700731
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
5. test_group_chat_add_new_member_activity_centre, id: 700732
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
6. test_group_chat_offline_pn, id: 3998
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

status-im-auto · 2022-08-02T16:11:40Z

100% of end-end tests have passed

Total executed tests: 1
Failed tests: 0
Passed tests: 1

Passed tests (1)

Click to expand

Class TestPublicChatBrowserOneDeviceMerged:

1. test_browser_delete_close_tabs, id: 702076
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

pavloburykh · 2022-08-03T13:42:14Z

@yqrashawn thanx for the fix. Tested and ready for merge.

yqrashawn changed the title ~~fix: set max option not work when send from qrcode WIP~~ fix: set max option not work when send from qrcode Jul 28, 2022

yqrashawn marked this pull request as ready for review July 28, 2022 11:04

yqrashawn requested a review from jakubgs as a code owner July 28, 2022 11:04

flexsurfer added the external label Jul 28, 2022

flexsurfer reviewed Jul 28, 2022

View reviewed changes

shadow-cljs.edn Outdated Show resolved Hide resolved

flexsurfer reviewed Jul 28, 2022

View reviewed changes

src/status_im/wallet/choose_recipient/core.cljs Outdated Show resolved Hide resolved

yqrashawn force-pushed the fix/set-max-after-qrcode branch from 398d8ba to ebd30a7 Compare July 28, 2022 13:32

Samyoul assigned yqrashawn Jul 29, 2022

yqrashawn force-pushed the fix/set-max-after-qrcode branch from 985a774 to 77bef25 Compare August 1, 2022 09:58

flexsurfer added the request-manual-qa label Aug 2, 2022

flexsurfer reviewed Aug 2, 2022

View reviewed changes

src/status_im/wallet/choose_recipient/core.cljs Outdated Show resolved Hide resolved

yqrashawn force-pushed the fix/set-max-after-qrcode branch from 77bef25 to fe1a347 Compare August 2, 2022 10:12

flexsurfer approved these changes Aug 2, 2022

View reviewed changes

yqrashawn added 4 commits August 2, 2022 19:59

fix: set max option not work when send from qrcode

19f0b3c

resolve status-im#11460 Signed-off-by: yqrashawn <namy.19@gmail.com>

chore: Revert taoensso.encore version

cab5204

refactor: remove enc/cond

8e28bf7

refactor: check gasPrice existence in detail

63147c4

yqrashawn force-pushed the fix/set-max-after-qrcode branch from fe1a347 to 63147c4 Compare August 2, 2022 11:59

pavloburykh self-assigned this Aug 2, 2022

pavloburykh added the Tested - OK label Aug 3, 2022

flexsurfer merged commit 71211ee into status-im:develop Aug 3, 2022

yqrashawn deleted the fix/set-max-after-qrcode branch August 3, 2022 16:02

ibrkhalil pushed a commit that referenced this pull request Aug 3, 2022

fix: set max option not work when send from qrcode (#13733)

0f68ffc

chrispader pushed a commit to chrispader/status-mobile that referenced this pull request Aug 4, 2022

fix: set max option not work when send from qrcode (status-im#13733)

6f6aa9d

siddarthkay pushed a commit to siddarthkay/status-react that referenced this pull request Aug 8, 2022

fix: set max option not work when send from qrcode (status-im#13733)

5e7c0b1

fix: set max option not work when send from qrcode #13733

fix: set max option not work when send from qrcode #13733

Conversation

yqrashawn commented Jul 28, 2022 • edited Loading

Summary

Platforms

Areas that maybe impacted

Steps to test

yqrashawn commented Jul 28, 2022

status-im-auto commented Jul 28, 2022 • edited Loading

Jenkins Builds

yqrashawn commented Jul 28, 2022

flexsurfer left a comment

Choose a reason for hiding this comment

status-im-auto commented Aug 2, 2022

97% of end-end tests have passed

Failed tests (3)

Class TestOneToOneChatMultipleSharedDevices:

Class TestSendTxDeviceMerged:

Class TestRestoreOneDeviceMerged:

Passed tests (84)

Class TestPublicChatBrowserOneDeviceMerged:

Class TestSendTxDeviceMerged:

Class TestPairingSyncMultipleDevicesMerged:

Class TestWalletManagementDeviceMerged:

Class TestOnboardingOneDeviceMerged:

Class TestPublicChatMultipleDeviceMerged:

Class TestKeycardTxOneDeviceMerged:

Class TestContactBlockMigrateKeycardMultipleSharedDevices:

Class TestOneToOneChatMultipleSharedDevices:

Class TestGroupChatMultipleDeviceMerged:

Class TestEnsStickersMultipleDevicesMerged:

Class TestRestoreOneDeviceMerged:

Class TestCommandsMultipleDevicesMerged:

status-im-auto commented Aug 2, 2022

100% of end-end tests have passed

Passed tests (1)

Class TestSendTxDeviceMerged:

status-im-auto commented Aug 2, 2022

97% of end-end tests have passed

Failed tests (3)

Class TestPublicChatBrowserOneDeviceMerged:

Class TestRestoreOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevices:

Passed tests (84)

Class TestOneToOneChatMultipleSharedDevices:

Class TestPublicChatMultipleDeviceMerged:

Class TestEnsStickersMultipleDevicesMerged:

Class TestPublicChatBrowserOneDeviceMerged:

Class TestWalletManagementDeviceMerged:

Class TestSendTxDeviceMerged:

Class TestRestoreOneDeviceMerged:

Class TestKeycardTxOneDeviceMerged:

Class TestCommandsMultipleDevicesMerged:

Class TestContactBlockMigrateKeycardMultipleSharedDevices:

Class TestOnboardingOneDeviceMerged:

Class TestPairingSyncMultipleDevicesMerged:

Class TestGroupChatMultipleDeviceMerged:

status-im-auto commented Aug 2, 2022

100% of end-end tests have passed

Passed tests (1)

Class TestPublicChatBrowserOneDeviceMerged:

pavloburykh commented Aug 3, 2022

yqrashawn commented Jul 28, 2022 •

edited

Loading

status-im-auto commented Jul 28, 2022 •

edited

Loading