status timeline: set image max width to avoid overflow of horizontally long images #13211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (4)
|
flexsurfer
reviewed
Mar 24, 2022
| :height image-max-dimension | ||
| :max-width :100% |
There was a problem hiding this comment.
could you please elaborate on how this will work?
There was a problem hiding this comment.
The modification here is to the container view which contains the image component.
problem : In case of horizontally long images the image width would be bigger than the device width and the image would overflow outside of the view.
Solution : set the container view to have a max-width of 100% which ensures that no matter what is the width of the image (which is in the child component) in question it would never overflow because of the max-width property.
Screenshot before fix :
Screenshot after fix :
There was a problem hiding this comment.
oh i see, but now the image is cut on the left?
There was a problem hiding this comment.
Its center aligned actually, Some images can be reallly long horizontally and to accommodate them there were 2 options :
- Either reduce the height to match the aspect ratio ( because of long length )
OR - Center align them with a fixed height
The second one seemed more readable to me given our constraints of device width
There was a problem hiding this comment.
Also when you tap on these images it opens them in a modal view in full
95% of end-end tests have passedFailed tests (4)Click to expand
Passed tests (75)Click to expand
|
flexsurfer
approved these changes
Mar 25, 2022
96% of end-end tests have passedFailed tests (3)Click to expand
Passed tests (76)Click to expand
|
|
@siddarthkay thank you for PR. Ready for merge. |
|
@siddarthkay please squash commits before merge |
|
@flexsurfer : yes I will take care from next time onwards, I messed up using the merge script with this PR :( |
siddarthkay
force-pushed
the
bug/13149-timeline-images-stretch-off-screen
branch
from
3c23a66
to
c4d2fba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[comment]: Fixes #13149
Platforms
Android
iOS
status: ready