Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12531 pairing] Sync read messages #12698

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Conversation

rasom
Copy link
Contributor

@rasom rasom commented Oct 12, 2021

fix #12531

status: ready

@rasom rasom self-assigned this Oct 12, 2021
@status-im-auto
Copy link
Member

status-im-auto commented Oct 12, 2021

Jenkins Builds

Click to see older builds (45)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 86ef583 #1 2021-10-12 10:56:49 ~20 min ios 📦ipa 📲
✔️ 86ef583 #1 2021-10-12 10:57:33 ~21 min android-e2e 📦apk 📲
✔️ 86ef583 #1 2021-10-12 10:58:02 ~21 min android 📦apk 📲
✔️ 01baa20 #2 2021-10-13 14:03:17 ~17 min android-e2e 📦apk 📲
✔️ 01baa20 #2 2021-10-13 14:03:19 ~17 min android 📦apk 📲
✔️ 01baa20 #2 2021-10-13 14:03:43 ~18 min ios 📦ipa 📲
✔️ d1eb23b #3 2021-10-14 09:36:10 ~17 min ios 📦ipa 📲
✔️ d1eb23b #3 2021-10-14 09:39:15 ~20 min android 📦apk 📲
✔️ d1eb23b #3 2021-10-14 09:39:23 ~20 min android-e2e 📦apk 📲
✔️ bb7c61d #4 2021-10-20 08:21:22 ~20 min android-e2e 📦apk 📲
✔️ bb7c61d #4 2021-10-20 08:21:24 ~20 min android 📦apk 📲
✔️ bb7c61d #4 2021-10-20 08:23:49 ~22 min ios 📦ipa 📲
✔️ 78d0da2 #5 2021-10-21 10:14:49 ~15 min ios 📦ipa 📲
✔️ 78d0da2 #5 2021-10-21 10:15:39 ~16 min android 📦apk 📲
✔️ 78d0da2 #5 2021-10-21 10:18:36 ~19 min android-e2e 📦apk 📲
bf6616e #6 2021-10-25 11:50:28 ~3 min ios 📄log
bf6616e #6 2021-10-25 11:50:48 ~4 min android-e2e 📄log
bf6616e #6 2021-10-25 11:51:13 ~4 min android 📄log
9e658b7 #7 2021-10-25 13:51:55 ~6 min android-e2e 📄log
9e658b7 #7 2021-10-25 13:52:33 ~7 min android 📄log
9e658b7 #7 2021-10-25 13:56:19 ~11 min ios 📄log
✔️ 09a0555 #8 2021-10-25 14:47:53 ~17 min ios 📦ipa 📲
✔️ 09a0555 #8 2021-10-25 14:49:39 ~19 min android 📦apk 📲
✔️ 09a0555 #8 2021-10-25 14:52:14 ~22 min android-e2e 📦apk 📲
✔️ 9806a91 #9 2021-10-26 09:07:31 ~17 min android 📦apk 📲
✔️ 9806a91 #9 2021-10-26 09:08:57 ~19 min ios 📦ipa 📲
✔️ 9806a91 #9 2021-10-26 09:11:11 ~21 min android-e2e 📦apk 📲
✔️ a9c7bb6 #10 2021-10-26 19:05:48 ~15 min android 📦apk 📲
✔️ a9c7bb6 #10 2021-10-26 19:08:37 ~18 min android-e2e 📦apk 📲
✔️ a9c7bb6 #10 2021-10-26 19:09:43 ~19 min ios 📦ipa 📲
✔️ 15177d5 #11 2021-10-27 10:10:51 ~21 min android-e2e 📦apk 📲
✔️ 15177d5 #11 2021-10-27 10:13:03 ~23 min android 📦apk 📲
✔️ 15177d5 #11 2021-10-27 10:15:41 ~26 min ios 📦ipa 📲
✔️ 15c09ea #12 2021-10-27 10:50:37 ~15 min android 📦apk 📲
✔️ 15c09ea #12 2021-10-27 10:53:48 ~18 min ios 📦ipa 📲
✔️ 15c09ea #12 2021-10-27 10:56:51 ~22 min android-e2e 📦apk 📲
✔️ ded6320 #13 2021-10-27 18:42:46 ~19 min ios 📦ipa 📲
✔️ ded6320 #13 2021-10-27 18:45:59 ~22 min android-e2e 📦apk 📲
✔️ ded6320 #13 2021-10-27 18:46:02 ~22 min android 📦apk 📲
✔️ 42d61bb #14 2021-10-28 08:29:58 ~17 min ios 📦ipa 📲
✔️ 42d61bb #14 2021-10-28 08:35:47 ~23 min android-e2e 📦apk 📲
✔️ 42d61bb #14 2021-10-28 08:35:52 ~23 min android 📦apk 📲
✔️ 1e95d83 #15 2021-10-29 07:23:06 ~17 min ios 📦ipa 📲
✔️ 1e95d83 #15 2021-10-29 07:30:13 ~24 min android-e2e 📦apk 📲
✔️ 1e95d83 #15 2021-10-29 07:30:21 ~24 min android 📦apk 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9e059b9 #16 2021-11-02 08:21:35 ~16 min android 📦apk 📲
✔️ 9e059b9 #16 2021-11-02 08:24:38 ~20 min android-e2e 📦apk 📲
✔️ 9e059b9 #16 2021-11-02 08:24:57 ~20 min ios 📦ipa 📲
✔️ adca53f #17 2021-11-02 10:48:22 ~17 min ios 📦ipa 📲
✔️ adca53f #17 2021-11-02 10:54:55 ~24 min android 📦apk 📲
✔️ adca53f #17 2021-11-02 10:54:59 ~24 min android-e2e 📦apk 📲

@rasom rasom force-pushed the feat/#12531-sync-read-messages branch 2 times, most recently from 01baa20 to d1eb23b Compare October 14, 2021 09:18
@rasom rasom marked this pull request as ready for review October 14, 2021 09:18
@status-im-auto
Copy link
Member

99% of end-end tests have passed

Total executed tests: 67
Failed tests: 1
Passed tests: 66
IDs of failed tests: 6272 

Failed tests (1)

Click to expand
  • Rerun tests

  • 1. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272

    Device 1: *Scrolling up to AccountElementButton*
    Device 1: *Find ReceiveTransactionButton by xpath:* `//*[@text="Receive"]`

    Device 1: ReceiveTransactionButton by xpath: `//*[@text="Receive"]` is not found on the screen

    Device sessions

    Passed tests (66)

    Click to expand

    1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    2. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    3. test_can_add_existing_ens_on_mainnet, id: 5502
    Device sessions

    4. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    5. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    6. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    7. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    8. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    9. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    10. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    11. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    12. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    13. test_delete_close_all_tabs, id: 5390
    Device sessions

    14. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    15. test_send_token_with_7_decimals, id: 5350
    Device sessions

    16. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    17. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    18. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    19. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    20. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    21. test_block_user_from_public_chat, id: 5786
    Device sessions

    22. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    23. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
    Device sessions

    24. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    25. test_edit_delete_message_in_one_to_one_and_public_chats, id: 695843
    Device sessions

    26. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    27. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    28. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    29. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    30. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    31. test_long_press_to_delete_chat, id: 5319
    Device sessions

    32. test_copy_and_paste_messages, id: 5317
    Device sessions

    33. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    34. test_unread_messages_counter_public_chat, id: 5360
    Device sessions

    35. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    36. test_mobile_data_usage_complex_settings, id: 6228
    Device sessions

    37. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    38. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    39. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    40. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    41. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    42. test_manage_assets, id: 5341
    Device sessions

    43. test_browser_managing_bookmarks, id: 6633
    Device sessions

    44. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    45. test_request_stt_from_daap, id: 5309
    Device sessions

    46. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    47. test_dapps_permissions, id: 5738
    Device sessions

    48. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    49. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    50. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    51. test_wallet_set_up, id: 5335
    Device sessions

    52. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    53. test_home_view, id: 5379
    Device sessions

    54. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    55. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    56. test_set_profile_picture, id: 6646
    Device sessions

    57. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    58. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    59. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    60. test_pass_phrase_validation, id: 5363
    Device sessions

    61. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    62. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    63. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    64. test_fetching_balance_after_offline, id: 6237
    Device sessions

    65. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    66. test_public_chat_messaging_emojis_timestamps, id: 5313
    Device sessions

    @rasom rasom force-pushed the feat/#12531-sync-read-messages branch from d1eb23b to bb7c61d Compare October 20, 2021 08:00
    @rasom rasom force-pushed the feat/#12531-sync-read-messages branch 2 times, most recently from 78d0da2 to bf6616e Compare October 25, 2021 11:46
    @churik
    Copy link
    Member

    churik commented Oct 25, 2021

    @rasom

    ISSUE 1: unread messages for group chats are not synced

    Steps:

    1. Device1, device2: restore multiaccount from seed phrase, pair devices
    2. Device1: create group chat with device 3
    3. Device3: send message to group chat
    4. Device1: open group chat to read message

    Expected result:
    no unread indicator for group chat is shown on Device2

    Actual result:
    unread indicator for group chat is shown on Device2 remains the same
    OS: IOS, Android

    Q 2: what about offline?

    Currently if Device1 and Device2 are paired and one of the devices is offline, unread messages won't sync if they were read until getting back paired device online.
    So if Device1 got message and read it (device2 was offline), when device2 came back online, message will be unread for Device2.
    Is that smth expected by now?

    @rasom
    Copy link
    Contributor Author

    rasom commented Oct 26, 2021

    @churik I believe that offline behaviour is same for all types of messages and this is not an objective of this PR.

    @rasom
    Copy link
    Contributor Author

    rasom commented Oct 26, 2021

    @churik issue 1 should be fixed

    @status-im-auto
    Copy link
    Member

    94% of end-end tests have passed

    Total executed tests: 69
    Failed tests: 4
    Passed tests: 65
    
    IDs of failed tests: 6226,5762,6228,6646 
    

    Failed tests (4)

    Click to expand
  • Rerun tests

  • 1. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226

    Device 2: Find 'Username' by 'xpath': `//*[starts-with(@text,'message test text 1')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/*[2]/android.widget.TextView`
    Device 2: 'Username' is 'test user1635333260 @statuse2e.eth'

    ENS username is not shown in 1-1 chat header

    Device sessions

    2. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762

    Device 2: =========================================================================
    Device 2: Find 'Button' by 'accessibility id': `contacts-button`

    Device 2: Button by accessibility id: `contacts-button` is not found on the screen

    Device sessions

    3. test_mobile_data_usage_complex_settings, id: 6228

    Device 1: Find 'Button' by 'xpath': `//*[@text="Use mobile data"]/following-sibling::android.widget.Switch[1]`
    Device 1: Find 'Button' by 'xpath': `//*[@text="Ask me when on mobile network"]/following-sibling::android.widget.Switch[1]`

    Chat history was not fetched with mobile data fetching ON

    Device sessions

    4. test_set_profile_picture, id: 6646

    Device 1: Tap on found: Button
    Device 1: Find 'Button' by 'xpath': `//*[@text="Generate keys"]`

    Device 1: Button by xpath: `//*[@text="Generate keys"]` is not found on the screen

    Device sessions

    Passed tests (65)

    Click to expand

    1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    2. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    3. test_can_add_existing_ens_on_mainnet, id: 5502
    Device sessions

    4. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    5. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    6. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    7. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    8. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    9. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    10. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    11. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    12. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    13. test_delete_close_all_tabs, id: 5390
    Device sessions

    14. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    15. test_send_token_with_7_decimals, id: 5350
    Device sessions

    16. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    17. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    18. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    19. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    20. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    21. test_block_user_from_public_chat, id: 5786
    Device sessions

    22. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    23. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
    Device sessions

    24. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    25. test_edit_delete_message_in_one_to_one_and_public_chats, id: 695843
    Device sessions

    26. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    27. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    28. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    29. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    30. test_long_press_to_delete_chat, id: 5319
    Device sessions

    31. test_copy_and_paste_messages, id: 5317
    Device sessions

    32. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    33. test_unread_messages_counter_public_chat, id: 5360
    Device sessions

    34. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    35. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    36. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    37. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    38. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    39. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    40. test_manage_assets, id: 5341
    Device sessions

    41. test_browser_managing_bookmarks, id: 6633
    Device sessions

    42. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    43. test_request_stt_from_daap, id: 5309
    Device sessions

    44. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    45. test_dapps_permissions, id: 5738
    Device sessions

    46. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    47. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    48. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    49. test_wallet_set_up, id: 5335
    Device sessions

    50. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    51. test_home_view, id: 5379
    Device sessions

    52. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    53. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    54. test_collectible_from_wallet, id: 5346
    Device sessions

    55. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    56. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    57. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    58. test_pass_phrase_validation, id: 5363
    Device sessions

    59. test_user_can_see_collectibles_on_rinkeby_after_account_recovering, id: 5381
    Device sessions

    60. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    61. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    62. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    63. test_fetching_balance_after_offline, id: 6237
    Device sessions

    64. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    65. test_public_chat_messaging_emojis_timestamps, id: 5313
    Device sessions

    @churik
    Copy link
    Member

    churik commented Oct 28, 2021

    Tested:

    • unread message before sync will be shown after initial sync
    • for all types of chats unread indicator is synced during several seconds if devices are online
    • if 1 of devices was offline, unread messages are synced right after getting back to online

    Devices:

    • IPhone 12 Mini (IOS 14)
    • IPhone 7 (IOS 13)
    • Xiaomi Mi Note 9 Pro (Android 10) unread messages before sync will shown after sync

    @status-im-auto
    Copy link
    Member

    50% of end-end tests have passed

    Total executed tests: 4
    Failed tests: 2
    Passed tests: 2
    
    IDs of failed tests: 6228,5762 
    

    Failed tests (2)

    Click to expand
  • Rerun tests

  • 1. test_mobile_data_usage_complex_settings, id: 6228

    Device 1: Find 'Button' by 'xpath': `//*[@text="Use mobile data"]/following-sibling::android.widget.Switch[1]`
    Device 1: Find 'Button' by 'xpath': `//*[@text="Ask me when on mobile network"]/following-sibling::android.widget.Switch[1]`

    Chat history was not fetched with mobile data fetching ON

    Device sessions

    2. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762

    # STEP: Contacts (secondary device): check unblocked user, new contact
    Device 2: Find 'Button' by 'accessibility id': `contacts-button`

    Device 2: Button by accessibility id: `contacts-button` is not found on the screen

    Device sessions

    Passed tests (2)

    Click to expand

    1. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    2. test_set_profile_picture, id: 6646
    Device sessions

    @status-im-auto
    Copy link
    Member

    50% of end-end tests have passed

    Total executed tests: 2
    Failed tests: 1
    Passed tests: 1
    
    IDs of failed tests: 6228 
    

    Failed tests (1)

    Click to expand
  • Rerun tests

  • 1. test_mobile_data_usage_complex_settings, id: 6228

    Device 1: Find 'Button' by 'xpath': `//*[@text="Use mobile data"]/following-sibling::android.widget.Switch[1]`
    Device 1: Find 'Button' by 'xpath': `//*[@text="Ask me when on mobile network"]/following-sibling::android.widget.Switch[1]`

    Chat history was not fetched with mobile data fetching ON

    Device sessions

    Passed tests (1)

    Click to expand

    1. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    @rasom rasom force-pushed the feat/#12531-sync-read-messages branch 2 times, most recently from 1e95d83 to 9e059b9 Compare November 2, 2021 08:04
    @rasom rasom force-pushed the feat/#12531-sync-read-messages branch from 9e059b9 to adca53f Compare November 2, 2021 10:30
    @rasom rasom merged commit adca53f into develop Nov 2, 2021
    @rasom rasom deleted the feat/#12531-sync-read-messages branch November 2, 2021 10:31
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    No open projects
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    Syncing of unread/read messages across devices
    5 participants