Add push notification on group chat invite #12440

briansztamfater · 2021-08-11T18:09:40Z

fixes #12330

Summary

This PR adds an OS notification when a contact invites you to a group chat

Platforms

Android
iOS: Push Notifications work different, IDK if this issue also applies to iOS but I can work on it if needed cc @churik please confirm

Functional

group chats

Steps to test

Open Status
Add user B as a contact
Send app to background
From user B, create a group chat with user A
Verify user A is receiving an OS notification

status: ready

status-im-auto · 2021-08-11T18:24:57Z

Jenkins Builds

Click to see older builds (35)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`7f2c276`	#1	2021-08-11 18:24:57	~15 min	`android`	📦`apk` 📲
✔️	`7f2c276`	#1	2021-08-11 18:26:52	~16 min	`android-e2e`	📦`apk` 📲
✔️	`7f2c276`	#1	2021-08-11 18:35:02	~25 min	`ios`	📦`ipa` 📲

✔️	`953bd59`	#2	2021-08-12 17:55:42	~14 min	`android-e2e`	📦`apk` 📲
✔️	`953bd59`	#2	2021-08-12 17:56:00	~15 min	`android`	📦`apk` 📲
✔️	`953bd59`	#2	2021-08-12 17:58:12	~17 min	`ios`	📦`ipa` 📲

✔️	`4e2e77e`	#3	2021-08-12 20:06:24	~14 min	`android`	📦`apk` 📲
✔️	`4e2e77e`	#3	2021-08-12 20:07:25	~15 min	`ios`	📦`ipa` 📲
✔️	`4e2e77e`	#3	2021-08-12 20:09:15	~17 min	`android-e2e`	📦`apk` 📲

❌	`7540ffa`	#4	2021-09-13 18:40:18	~30 sec	`android-e2e`	📄`log`
❌	`7540ffa`	#4	2021-09-13 18:40:18	~28 sec	`android`	📄`log`
❌	`7540ffa`	#4	2021-09-13 18:40:20	~30 sec	`ios`	📄`log`

✔️	`9843660`	#5	2021-09-13 18:56:29	~15 min	`android-e2e`	📦`apk` 📲
✔️	`9843660`	#5	2021-09-13 18:59:20	~18 min	`android`	📦`apk` 📲
✔️	`9843660`	#5	2021-09-13 19:01:17	~19 min	`ios`	📦`ipa` 📲

✔️	`582cc2d`	#6	2021-09-13 21:24:37	~15 min	`android-e2e`	📦`apk` 📲
✔️	`582cc2d`	#6	2021-09-13 21:25:52	~16 min	`android`	📦`apk` 📲
✔️	`582cc2d`	#6	2021-09-13 21:28:54	~19 min	`ios`	📦`ipa` 📲

✔️	`2747806`	#7	2021-09-13 22:46:37	~15 min	`android-e2e`	📦`apk` 📲
✔️	`2747806`	#7	2021-09-13 22:46:54	~15 min	`android`	📦`apk` 📲
✔️	`2747806`	#7	2021-09-13 22:49:09	~18 min	`ios`	📦`ipa` 📲

✔️	`a11f089`	#8	2021-09-13 23:11:28	~14 min	`android`	📦`apk` 📲
✔️	`a11f089`	#8	2021-09-13 23:12:37	~15 min	`android-e2e`	📦`apk` 📲
✔️	`a11f089`	#8	2021-09-13 23:15:03	~18 min	`ios`	📦`ipa` 📲

✔️	`580913a`	#10	2021-09-15 16:23:42	~14 min	`android-e2e`	📦`apk` 📲
✔️	`580913a`	#10	2021-09-15 16:25:14	~16 min	`android`	📦`apk` 📲
✔️	`580913a`	#10	2021-09-15 16:34:27	~25 min	`ios`	📦`ipa` 📲

✔️	`f0ee25e`	#9	2021-09-15 16:25:56	~17 min	`android-e2e`	📦`apk` 📲
✔️	`f0ee25e`	#9	2021-09-15 16:27:32	~19 min	`android`	📦`apk` 📲

✔️	`a5daa37`	#11	2021-09-15 17:12:39	~15 min	`android`	📦`apk` 📲
✔️	`a5daa37`	#11	2021-09-15 17:13:25	~16 min	`android-e2e`	📦`apk` 📲
✔️	`a5daa37`	#11	2021-09-15 17:18:11	~21 min	`ios`	📦`ipa` 📲

✔️	`61ce927`	#12	2021-09-15 17:41:24	~16 min	`android`	📦`apk` 📲
✔️	`61ce927`	#12	2021-09-15 17:43:07	~18 min	`android-e2e`	📦`apk` 📲
✔️	`61ce927`	#12	2021-09-15 17:43:23	~18 min	`ios`	📦`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`de74da6`	#13	2021-09-16 18:37:29	~15 min	`android`	📦`apk` 📲
✔️	`de74da6`	#13	2021-09-16 18:39:09	~17 min	`ios`	📦`ipa` 📲
✔️	`de74da6`	#13	2021-09-16 18:40:09	~18 min	`android-e2e`	📦`apk` 📲

✔️	`1ab9956`	#14	2021-09-27 14:31:58	~16 min	`ios`	📦`ipa` 📲
✔️	`1ab9956`	#14	2021-09-27 14:34:28	~19 min	`android-e2e`	📦`apk` 📲
✔️	`1ab9956`	#14	2021-09-27 14:34:33	~19 min	`android`	📦`apk` 📲
✔️	`1ab9956`	#15	2021-09-28 09:45:52	~20 min	`android-e2e`	📦`apk` 📲

status-im-auto · 2021-09-15T11:12:54Z

77% of end-end tests have passed

Total executed tests: 69
Failed tests: 16
Passed tests: 53

IDs of failed tests: 6244,5314,5412,5350,5758,6645,6272,5381,6228,6633,5309,6263,5346,6249,6240,6237

Failed tests (16)

Click to expand

Rerun tests

1. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
Device 1: Swiping up Device 1: Waiting 400 seconds for ADI to display asset `Device 1: Balance ADI 0 is not changed during 400 seconds!` Device sessions Device 1: Steps, video, logs Failure screenshot
2. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
Device 1: Swiping up Device 1: Waiting 400 seconds for STT to display asset `Device 1: Balance STT 0 is not changed during 400 seconds!` Device sessions Device 1: Steps, video, logs Failure screenshot
3. test_insufficient_funds_wallet_positive_balance, id: 5412
Device 1: Swiping up Device 1: Waiting 400 seconds for STT to display asset `Device 1: Balance STT 0 is not changed during 400 seconds!` Device sessions Device 1: Steps, video, logs Failure screenshot
4. test_send_token_with_7_decimals, id: 5350
Device 1: Swiping up Device 1: Waiting 400 seconds for ADI to display asset `Device 1: Balance ADI 0 is not changed during 400 seconds!` Device sessions Device 1: Steps, video, logs Failure screenshot
5. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
Device 1: Getting LXS amount Device 1: Scrolling down to SilentButton Device 1: SilentButton by xpath:* `//android.view.ViewGroup[@content-desc=':LXS-asset-value']//android.widget.TextView[1]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot
6. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
Device 1: Getting ADI amount Device 1: Scrolling down to SilentButton Device 1: SilentButton by xpath:* `//android.view.ViewGroup[@content-desc=':ADI-asset-value']//android.widget.TextView[1]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot
7. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
Device 1: Swiping up Device 1: Waiting 400 seconds for ADI to display asset `Device 1: Balance ADI 0 is not changed during 400 seconds!` Device sessions Device 1: Steps, video, logs Failure screenshot
8. test_user_can_see_all_own_assets_after_account_recovering, id: 5381
Device 1: Find Button by xpath: `//[@text="Collectibles"]` Device 1: Tap on found Button* `Device 1: User collectibles token name in not shown` Device sessions Device 1: Steps, video, logs Failure screenshot
9. test_mobile_data_usage_complex_settings, id: 6228
Device 1: Find Button by xpath: `//[@text="Use mobile data"]/following-sibling::android.widget.Switch[1]` Device 1: Find Button by xpath:* `//*[@text="Ask me when on mobile network"]/following-sibling::android.widget.Switch[1]` `Chat history was not fetched with mobile data fetching ON` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
10. test_browser_managing_bookmarks, id: 6633
Device 1: Editing bookmark name to 'My Fav Status' Device 1: Find EditBox by accessibility id: `bookmark-input` Device 1: EditBox by accessibility id: `bookmark-input` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot
11. test_request_stt_from_daap, id: 5309
Device 1: Getting STT amount Device 1: Scrolling down to SilentButton Device 1: SilentButton by xpath:* `//android.view.ViewGroup[@content-desc=':STT-asset-value']//android.widget.TextView[1]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot
12. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
Device 2: Getting STT amount Device 2: Scrolling down to SilentButton Device 2: SilentButton by xpath:* `//android.view.ViewGroup[@content-desc=':STT-asset-value']//android.widget.TextView[1]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
13. test_collectible_from_wallet, id: 5346
Device 1: Check collectibles amount in wallet Device 1: ========================================================================= Device 1: Text by xpath:`//*[@text='CryptoKitties']//following-sibling::android.widget.TextView` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot
14. test_keycard_request_stt_from_daap, id: 6249
Device 1: Getting STT amount Device 1: Scrolling down to SilentButton Device 1: SilentButton by xpath:* `//android.view.ViewGroup[@content-desc=':STT-asset-value']//android.widget.TextView[1]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot
15. test_restore_account_from_mnemonic_to_keycard, id: 6240
Device 1: Getting ADI amount Device 1: Scrolling down to SilentButton Device 1: SilentButton by xpath:* `//android.view.ViewGroup[@content-desc=':ADI-asset-value']//android.widget.TextView[1]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot
16. test_fetching_balance_after_offline, id: 6237
Device 1: Swiping up Device 1: Waiting 400 seconds for STT to display asset `Device 1: Balance STT 0 is not changed during 400 seconds!` Device sessions Device 1: Steps, video, logs Failure screenshot

Passed tests (53)

Click to expand

1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_add_account_to_multiaccount_instance_generate_new, id: 6224
Device sessions Device 1: Steps, video, logs
3. test_keycard_can_see_all_transactions_in_history, id: 6291
Device sessions Device 1: Steps, video, logs
4. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
Device sessions Device 1: Steps, video, logs
5. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
Device sessions Device 1: Steps, video, logs
6. test_open_public_chat_using_deep_link, id: 5396
Device sessions Device 1: Steps, video, logs
7. test_offline_add_new_group_chat_member, id: 3998
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
8. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_delete_close_all_tabs, id: 5390
Device sessions Device 1: Steps, video, logs
10. test_create_new_group_chat_messaging_pn_delivered, id: 3994
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
11. test_delete_chats_via_delete_button_rejoin, id: 5387
Device sessions Device 1: Steps, video, logs
12. test_send_transaction_set_recipient_options, id: 6328
Device sessions Device 1: Steps, video, logs
13. test_keycard_sign_message_and_transactions_from_daap, id: 6251
Device sessions Device 1: Steps, video, logs
14. test_recover_account_from_new_user_seedphrase, id: 6296
Device sessions Device 1: Steps, video, logs
15. test_block_user_from_public_chat, id: 5786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
16. test_send_audio_message_with_push_notification_check, id: 6316
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
17. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
Device sessions Device 1: Steps, video, logs
18. test_edit_delete_message_in_one_to_one_and_public_chats, id: 695843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
19. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
20. test_keycard_send_eth_from_wallet_to_address, id: 6289
Device sessions Device 1: Steps, video, logs
21. test_keycard_create_login_restore_unlock_same_seed, id: 5689
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
22. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
23. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
24. test_long_press_to_delete_chat, id: 5319
Device sessions Device 1: Steps, video, logs
25. test_copy_and_paste_messages, id: 5317
Device sessions Device 1: Steps, video, logs
26. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
Device sessions Device 1: Steps, video, logs
27. test_unread_messages_counter_public_chat, id: 5360
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
28. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
Device sessions Device 1: Steps, video, logs
29. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
Device sessions Device 1: Steps, video, logs
30. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
31. test_send_eth_in_1_1_chat_transaction_push, id: 6253
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
32. test_install_pack_and_send_sticker, id: 5782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
33. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
Device sessions Device 1: Steps, video, logs
34. test_manage_assets, id: 5341
Device sessions Device 1: Steps, video, logs
35. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
Device sessions Device 1: Steps, video, logs
36. test_can_use_purchased_stickers_on_recovered_account, id: 5783
Device sessions Device 1: Steps, video, logs
37. test_dapps_permissions, id: 5738
Device sessions Device 1: Steps, video, logs
38. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
Device sessions Device 1: Steps, video, logs
39. test_send_eth_to_ens_in_chat, id: 6279
Device sessions Device 1: Steps, video, logs
40. test_share_copy_contact_code_and_wallet_address, id: 5323
Device sessions Device 1: Steps, video, logs
41. test_wallet_set_up, id: 5335
Device sessions Device 1: Steps, video, logs
42. test_send_transaction_with_custom_token, id: 6208
Device sessions Device 1: Steps, video, logs
43. test_home_view, id: 5379
Device sessions Device 1: Steps, video, logs
44. test_can_add_existing_ens, id: 5502
Device sessions Device 1: Steps, video, logs
45. test_logcat_backup_recovery_phrase, id: 5419
Device sessions Device 1: Steps, video, logs
46. test_set_profile_picture, id: 6646
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
47. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
48. test_pass_phrase_validation, id: 5363
Device sessions Device 1: Steps, video, logs
49. test_keycard_send_eth_in_1_1_chat, id: 6293
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
50. test_send_and_open_links_with_previews, id: 5373
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
51. test_reactions_to_message_in_chats, id: 6315
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
52. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
53. test_public_chat_messaging_emojis_timestamps, id: 5313
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

status-im-auto · 2021-09-15T12:40:57Z

12% of end-end tests have passed

Total executed tests: 16
Failed tests: 14
Passed tests: 2

IDs of failed tests: 6244,5314,5412,5350,5758,6645,6272,5381,5309,6263,5346,6249,6240,6237

Failed tests (14)

Click to expand

Rerun tests

1. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
Device 1: Swiping up Device 1: Waiting 400 seconds for ADI to display asset `Device 1: Balance ADI 0 is not changed during 400 seconds!` Device sessions Device 1: Steps, video, logs Failure screenshot
2. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
Device 1: Swiping up Device 1: Waiting 400 seconds for STT to display asset `Device 1: Balance STT 0 is not changed during 400 seconds!` Device sessions Device 1: Steps, video, logs Failure screenshot
3. test_insufficient_funds_wallet_positive_balance, id: 5412
Device 1: Swiping up Device 1: Waiting 400 seconds for STT to display asset `Device 1: Balance STT 0 is not changed during 400 seconds!` Device sessions Device 1: Steps, video, logs Failure screenshot
4. test_send_token_with_7_decimals, id: 5350
Device 1: Swiping up Device 1: Waiting 400 seconds for ADI to display asset `Device 1: Balance ADI 0 is not changed during 400 seconds!` Device sessions Device 1: Steps, video, logs Failure screenshot
5. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
Device 1: Getting LXS amount Device 1: Scrolling down to SilentButton Device 1: SilentButton by xpath:* `//android.view.ViewGroup[@content-desc=':LXS-asset-value']//android.widget.TextView[1]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot
6. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
Device 1: Getting ADI amount Device 1: Scrolling down to SilentButton Device 1: SilentButton by xpath:* `//android.view.ViewGroup[@content-desc=':ADI-asset-value']//android.widget.TextView[1]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot
7. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
Device 1: Swiping up Device 1: Waiting 400 seconds for ADI to display asset `Device 1: Balance ADI 0 is not changed during 400 seconds!` Device sessions Device 1: Steps, video, logs Failure screenshot
8. test_user_can_see_all_own_assets_after_account_recovering, id: 5381
Device 1: Find Button by xpath: `//[@text="Collectibles"]` Device 1: Tap on found Button* `Device 1: User collectibles token name in not shown` Device sessions Device 1: Steps, video, logs Failure screenshot
9. test_request_stt_from_daap, id: 5309
Device 1: Getting STT amount Device 1: Scrolling down to SilentButton Device 1: SilentButton by xpath:* `//android.view.ViewGroup[@content-desc=':STT-asset-value']//android.widget.TextView[1]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot
10. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
Device 2: Getting STT amount Device 2: Scrolling down to SilentButton Device 2: SilentButton by xpath:* `//android.view.ViewGroup[@content-desc=':STT-asset-value']//android.widget.TextView[1]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
11. test_collectible_from_wallet, id: 5346
Device 1: Check collectibles amount in wallet Device 1: ========================================================================= Device 1: Text by xpath:`//*[@text='CryptoKitties']//following-sibling::android.widget.TextView` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot
12. test_keycard_request_stt_from_daap, id: 6249
Device 1: Getting STT amount Device 1: Scrolling down to SilentButton Device 1: SilentButton by xpath:* `//android.view.ViewGroup[@content-desc=':STT-asset-value']//android.widget.TextView[1]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot
13. test_restore_account_from_mnemonic_to_keycard, id: 6240
Device 1: Getting ADI amount Device 1: Scrolling down to SilentButton Device 1: SilentButton by xpath:* `//android.view.ViewGroup[@content-desc=':ADI-asset-value']//android.widget.TextView[1]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot
14. test_fetching_balance_after_offline, id: 6237
Device 1: Swiping up Device 1: Waiting 400 seconds for STT to display asset `Device 1: Balance STT 0 is not changed during 400 seconds!` Device sessions Device 1: Steps, video, logs Failure screenshot

Passed tests (2)

Click to expand

1. test_mobile_data_usage_complex_settings, id: 6228
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_browser_managing_bookmarks, id: 6633
Device sessions Device 1: Steps, video, logs

qoqobolo · 2021-09-15T15:40:22Z

@briansztamfater thanks for your work!

ISSUE 1: If UserA invites UserB and UserC to the group chat, and UserB joins the group, then on the UserC's device the invitation notification from UserA is displayed as an invitation from UserB

Steps:

UserA (Keen Courageous Bongo), UserB (Little Knobby Bear), UserC (Nice Positive Hamadryas) add each other to contacts
UserB and UserC enable PNs
UserC puts the app in the background
UserA creates a group with UserB and UserC
UserB joins the group
UserC checks the PN

At the beginning of the video, PN from Keen Courageous Bongo turns into PN from Little Knobby Bear as he joins the group

video_2021-09-15_17-25-18.mp4

qoqobolo · 2021-09-15T15:41:02Z

iOS: Push Notifications work different, IDK if this issue also applies to iOS but I can work on it if needed cc @churik please confirm

Also, confirm that the issue for iOS will be logged separately, so now only PNs on Android should be fixed in the current PR.

briansztamfater · 2021-09-15T16:09:54Z

Thanks @qoqobolo, already working on a fix for that issue.

briansztamfater · 2021-09-15T17:24:32Z

@qoqobolo issue should be fixed now

qoqobolo · 2021-09-16T09:36:16Z

@briansztamfater thank you! No other issues were found.
PR can be merged.

briansztamfater · 2021-09-27T14:16:40Z

@qoqobolo Just merged the status-go PR and updated this one, can you please do some quick re-test to check I didn't break anything? If everything is fine I can merge then.

qoqobolo · 2021-09-27T14:19:32Z

@briansztamfater yes, sure

status-im-auto · 2021-09-27T15:42:50Z

0% of end-end tests have passed

Total executed tests: 25
Failed tests: 25
Passed tests: 0

IDs of failed tests: 5782,6293,6226,6646,6283,5315,5689,5310,695843,5360,6265,6305,6316,3998,5762,3994,5313,6315,5373,5786,6228,5332,6253,6279,6263

Failed tests (25)

Click to expand

Rerun tests

1. test_install_pack_and_send_sticker, id: 5782
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
2. test_keycard_send_eth_in_1_1_chat, id: 6293
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
3. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
4. test_set_profile_picture, id: 6646
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
5. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
6. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
7. test_keycard_create_login_restore_unlock_same_seed, id: 5689
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
8. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
9. test_edit_delete_message_in_one_to_one_and_public_chats, id: 695843
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
10. test_unread_messages_counter_public_chat, id: 5360
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
11. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
12. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
13. test_send_audio_message_with_push_notification_check, id: 6316
`ERROR The test with session id 7bc40e33438b44d59356b60527cd70a2 has already finished, and can't receive further commands. You can learn more at https://app.saucelabs.com/tests/7bc40e33438b44d59356b60527cd70a2 For help, please check https://docs.s`
14. test_offline_add_new_group_chat_member, id: 3998
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
15. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
16. test_create_new_group_chat_messaging_pn_delivered, id: 3994
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
17. test_public_chat_messaging_emojis_timestamps, id: 5313
`ERROR The test with session id d557e50a16394ee3809789cff80c128c has already finished, and can't receive further commands. You can learn more at https://app.saucelabs.com/tests/d557e50a16394ee3809789cff80c128c For help, please check https://docs.s`
18. test_reactions_to_message_in_chats, id: 6315
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
19. test_send_and_open_links_with_previews, id: 5373
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
20. test_block_user_from_public_chat, id: 5786
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
21. test_mobile_data_usage_complex_settings, id: 6228
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
22. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
23. test_send_eth_in_1_1_chat_transaction_push, id: 6253
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
24. test_send_eth_to_ens_in_chat, id: 6279
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
25. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`

status-im-auto · 2021-09-28T08:15:25Z

0% of end-end tests have passed

Total executed tests: 25
Failed tests: 25
Passed tests: 0

IDs of failed tests: 5689,5782,6316,6283,5373,5313,5360,6293,695843,6228,6279,6226,5315,6253,5310,6263,5786,6305,5762,3994,6315,6646,3998,5332,6265

Failed tests (25)

Click to expand

Rerun tests

1. test_keycard_create_login_restore_unlock_same_seed, id: 5689
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
2. test_install_pack_and_send_sticker, id: 5782
`Sauce could not start your job. For more information on what happened, please visit https://app.saucelabs.com/tests/68df5c6701924405a87b6828d28e48e5`
3. test_send_audio_message_with_push_notification_check, id: 6316
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
4. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
5. test_send_and_open_links_with_previews, id: 5373
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
6. test_public_chat_messaging_emojis_timestamps, id: 5313
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
7. test_unread_messages_counter_public_chat, id: 5360
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
8. test_keycard_send_eth_in_1_1_chat, id: 6293
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
9. test_edit_delete_message_in_one_to_one_and_public_chats, id: 695843
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
10. test_mobile_data_usage_complex_settings, id: 6228
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
11. test_send_eth_to_ens_in_chat, id: 6279
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
12. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
13. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
14. test_send_eth_in_1_1_chat_transaction_push, id: 6253
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
15. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
16. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
17. test_block_user_from_public_chat, id: 5786
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
18. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
19. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
20. test_create_new_group_chat_messaging_pn_delivered, id: 3994
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
21. test_reactions_to_message_in_chats, id: 6315
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
22. test_set_profile_picture, id: 6646
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
23. test_offline_add_new_group_chat_member, id: 3998
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
24. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`
25. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`

status-im-auto · 2021-09-28T08:47:26Z

0% of end-end tests have passed

Total executed tests: 1
Failed tests: 1
Passed tests: 0

IDs of failed tests: 5689

Failed tests (1)

Click to expand

Rerun tests

1. test_keycard_create_login_restore_unlock_same_seed, id: 5689
`Infrastructure Error -- The Sauce VMs failed to start the browser or device. For more info, please check https://docs.saucelabs.com/dev/error-messages`

status-im-auto · 2021-09-28T10:45:42Z

100% of end-end tests have passed

Total executed tests: 25
Failed tests: 0
Passed tests: 25

Passed tests (25)

Click to expand

1. test_keycard_create_login_restore_unlock_same_seed, id: 5689
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_install_pack_and_send_sticker, id: 5782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_send_audio_message_with_push_notification_check, id: 6316
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_send_and_open_links_with_previews, id: 5373
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_public_chat_messaging_emojis_timestamps, id: 5313
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_unread_messages_counter_public_chat, id: 5360
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_keycard_send_eth_in_1_1_chat, id: 6293
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_edit_delete_message_in_one_to_one_and_public_chats, id: 695843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_mobile_data_usage_complex_settings, id: 6228
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
11. test_send_eth_to_ens_in_chat, id: 6279
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
12. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
13. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
14. test_send_eth_in_1_1_chat_transaction_push, id: 6253
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
15. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
16. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
17. test_block_user_from_public_chat, id: 5786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
18. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
19. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
20. test_create_new_group_chat_messaging_pn_delivered, id: 3994
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
21. test_reactions_to_message_in_chats, id: 6315
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
22. test_set_profile_picture, id: 6646
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
23. test_offline_add_new_group_chat_member, id: 3998
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
24. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
25. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

qoqobolo · 2021-09-28T10:52:15Z

@briansztamfater looks good to me, let's merge!

Signed-off-by: Brian Sztamfater <brian@status.im>

briansztamfater marked this pull request as draft August 11, 2021 18:09

briansztamfater changed the title ~~[WIP] Add push notification on group invite chat~~ [WIP] Add push notification on group chat invite Aug 11, 2021

briansztamfater force-pushed the fix/group-chat-invite-notification branch 2 times, most recently from 953bd59 to 4e2e77e Compare August 12, 2021 19:51

flexsurfer assigned briansztamfater Aug 13, 2021

briansztamfater force-pushed the fix/group-chat-invite-notification branch 2 times, most recently from 7540ffa to 9843660 Compare September 13, 2021 18:40

briansztamfater marked this pull request as ready for review September 13, 2021 19:46

briansztamfater changed the title ~~[WIP] Add push notification on group chat invite~~ Add push notification on group chat invite Sep 13, 2021

briansztamfater requested review from flexsurfer, shivekkhurana and bitgamma September 13, 2021 19:47

briansztamfater force-pushed the fix/group-chat-invite-notification branch 3 times, most recently from 2747806 to a11f089 Compare September 13, 2021 22:56

flexsurfer approved these changes Sep 14, 2021

View reviewed changes

briansztamfater added request-manual-qa bug labels Sep 14, 2021

qoqobolo self-assigned this Sep 15, 2021

briansztamfater force-pushed the fix/group-chat-invite-notification branch 2 times, most recently from f0ee25e to 580913a Compare September 15, 2021 16:08

briansztamfater force-pushed the fix/group-chat-invite-notification branch 2 times, most recently from a5daa37 to 61ce927 Compare September 15, 2021 17:24

qoqobolo added the Tested - OK label Sep 16, 2021

qoqobolo mentioned this pull request Sep 16, 2021

Fix profile image in push notifications #12427

Merged

briansztamfater force-pushed the fix/group-chat-invite-notification branch from 61ce927 to de74da6 Compare September 16, 2021 18:21

briansztamfater force-pushed the fix/group-chat-invite-notification branch from de74da6 to 1ab9956 Compare September 27, 2021 14:15

Add push notification on group invite chat

5c0102c

Signed-off-by: Brian Sztamfater <brian@status.im>

briansztamfater force-pushed the fix/group-chat-invite-notification branch from 1ab9956 to 5c0102c Compare September 28, 2021 12:07

briansztamfater merged commit 5c0102c into develop Sep 28, 2021

briansztamfater deleted the fix/group-chat-invite-notification branch September 28, 2021 12:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add push notification on group chat invite #12440

Add push notification on group chat invite #12440

briansztamfater commented Aug 11, 2021 •

edited

Loading

status-im-auto commented Aug 11, 2021 •

edited

Loading

status-im-auto commented Sep 15, 2021

status-im-auto commented Sep 15, 2021

qoqobolo commented Sep 15, 2021

qoqobolo commented Sep 15, 2021

briansztamfater commented Sep 15, 2021

briansztamfater commented Sep 15, 2021

qoqobolo commented Sep 16, 2021

briansztamfater commented Sep 27, 2021

qoqobolo commented Sep 27, 2021

status-im-auto commented Sep 27, 2021

status-im-auto commented Sep 28, 2021

status-im-auto commented Sep 28, 2021

status-im-auto commented Sep 28, 2021

qoqobolo commented Sep 28, 2021

Add push notification on group chat invite #12440

Add push notification on group chat invite #12440

Conversation

briansztamfater commented Aug 11, 2021 • edited Loading

Summary

Platforms

Functional

Steps to test

status-im-auto commented Aug 11, 2021 • edited Loading

Jenkins Builds

status-im-auto commented Sep 15, 2021

77% of end-end tests have passed

Failed tests (16)

Passed tests (53)

status-im-auto commented Sep 15, 2021

12% of end-end tests have passed

Failed tests (14)

Passed tests (2)

qoqobolo commented Sep 15, 2021

ISSUE 1: If UserA invites UserB and UserC to the group chat, and UserB joins the group, then on the UserC's device the invitation notification from UserA is displayed as an invitation from UserB

qoqobolo commented Sep 15, 2021

briansztamfater commented Sep 15, 2021

briansztamfater commented Sep 15, 2021

qoqobolo commented Sep 16, 2021

briansztamfater commented Sep 27, 2021

qoqobolo commented Sep 27, 2021

status-im-auto commented Sep 27, 2021

0% of end-end tests have passed

Failed tests (25)

status-im-auto commented Sep 28, 2021

0% of end-end tests have passed

Failed tests (25)

status-im-auto commented Sep 28, 2021

0% of end-end tests have passed

Failed tests (1)

status-im-auto commented Sep 28, 2021

100% of end-end tests have passed

Passed tests (25)

qoqobolo commented Sep 28, 2021

briansztamfater commented Aug 11, 2021 •

edited

Loading

status-im-auto commented Aug 11, 2021 •

edited

Loading