Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Show replies in activity center #12266

Merged
merged 1 commit into from
Jul 23, 2021
Merged

📝 Show replies in activity center #12266

merged 1 commit into from
Jul 23, 2021

Conversation

briansztamfater
Copy link
Member

@briansztamfater briansztamfater commented Jun 30, 2021 •
edited
Loading

fixes #12239

Summary

This PR implements reply notifications to activity center.

Screenshots

Captura de Pantalla 2021-07-08 a la(s) 17 28 39

Testing notes

Reply notifications only work for groups and communities for the time being

Platforms

  • Android
  • iOS

Functional

  • activity center

Steps to test

  • Open Status
  • Open a group or community chat
  • Send a message replying to some user
  • Receive notification in activity center

status: ready

@briansztamfater briansztamfater added this to the Release 1.15 milestone Jun 30, 2021
@briansztamfater briansztamfater self-assigned this Jun 30, 2021
@briansztamfater briansztamfater marked this pull request as draft June 30, 2021 19:07
@briansztamfater briansztamfater linked an issue Jun 30, 2021 that may be closed by this pull request
Show replies in activity center #12239
Closed
@status-im-auto
Copy link
Member

status-im-auto commented Jun 30, 2021 •
edited
Loading

Jenkins Builds

Click to see older builds (39)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 5c4fb4a #1 2021-06-30 19:24:43 ~16 min ios 📦ipa 📲
✖️ 5c4fb4a #1 2021-06-30 19:26:09 ~18 min android 📦apk 📲
❌ 5c4fb4a #2 2021-07-02 19:43:37 ~33 sec android 📄log
❌ 5c4fb4a #2 2021-07-02 19:43:38 ~34 sec android-e2e 📄log
❌ 5c4fb4a #2 2021-07-02 19:43:42 ~36 sec ios 📄log
✖️ 6749c34 #3 2021-07-06 15:09:32 ~14 min android-e2e 📦apk 📲
✖️ 6749c34 #3 2021-07-06 15:16:06 ~21 min android 📦apk 📲
✖️ 92e4c7b #4 2021-07-06 18:11:08 ~14 min android 📦apk 📲
✖️ 92e4c7b #4 2021-07-06 18:11:13 ~15 min android-e2e 📦apk 📲
✖️ 92e4c7b #4 2021-07-06 18:13:50 ~17 min ios 📦ipa 📲
❌ 5d6370e #5 2021-07-08 20:39:59 ~17 sec android 📄log
❌ 5d6370e #5 2021-07-08 20:40:01 ~19 sec ios 📄log
❌ 5d6370e #5 2021-07-08 20:40:10 ~28 sec android-e2e 📄log
✔️ ccce06a #6 2021-07-08 20:56:57 ~15 min android-e2e 📦apk 📲
✔️ ccce06a #6 2021-07-08 20:58:33 ~16 min android 📦apk 📲
✔️ bd92d08 #7 2021-07-08 20:58:14 ~14 min android-e2e 📦apk 📲
✔️ bd92d08 #7 2021-07-08 21:10:56 ~27 min android 📦apk 📲
✔️ 5ed1716 #8 2021-07-08 20:58:43 ~13 min android 📦apk 📲
✔️ 5ed1716 #8 2021-07-08 21:09:26 ~24 min ios 📦ipa 📲
✔️ 5ed1716 #8 2021-07-08 21:10:51 ~26 min android-e2e 📦apk 📲
✔️ 1d18c18 #9 2021-07-08 21:23:55 ~14 min android-e2e 📦apk 📲
✔️ 1d18c18 #9 2021-07-08 21:24:04 ~14 min android 📦apk 📲
✔️ 1d18c18 #9 2021-07-08 21:27:02 ~17 min ios 📦ipa 📲
✔️ 1d18c18 #10 2021-07-13 08:51:04 ~34 min ios 📦ipa 📲
✖️ babc5a4 #10 2021-07-13 19:34:39 ~18 min android-e2e 📦apk 📲
✖️ babc5a4 #10 2021-07-13 19:34:42 ~18 min android 📦apk 📲
✖️ babc5a4 #11 2021-07-13 19:37:16 ~21 min ios 📦ipa 📲
✖️ eaf31af #11 2021-07-13 21:20:10 ~15 min android-e2e 📦apk 📲
✖️ eaf31af #11 2021-07-13 21:22:46 ~17 min android 📦apk 📲
✖️ eaf31af #12 2021-07-13 21:25:16 ~20 min ios 📦ipa 📲
✔️ c621669 #12 2021-07-13 21:24:12 ~15 min android 📦apk 📲
✔️ c621669 #13 2021-07-13 21:33:31 ~24 min ios 📦ipa 📲
✔️ c621669 #12 2021-07-13 21:38:05 ~29 min android-e2e 📦apk 📲
✔️ e7cf394 #13 2021-07-14 20:32:53 ~13 min android 📦apk 📲
✔️ e7cf394 #13 2021-07-14 20:32:58 ~13 min android-e2e 📦apk 📲
✔️ e7cf394 #14 2021-07-14 20:37:11 ~17 min ios 📦ipa 📲
✔️ 6e738a1 #15 2021-07-15 20:50:44 ~10 min android 📦apk 📲
✔️ 6e738a1 #15 2021-07-15 20:51:20 ~11 min android-e2e 📦apk 📲
✔️ 6e738a1 #16 2021-07-15 21:01:08 ~20 min ios 📦ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3333e0c #14 2021-07-15 20:51:53 ~12 min android-e2e 📦apk 📲
✔️ 3333e0c #14 2021-07-15 20:55:31 ~16 min android 📦apk 📲
✔️ 3333e0c #15 2021-07-15 21:03:24 ~24 min ios 📦ipa 📲
✔️ 6c842dc #16 2021-07-23 18:01:22 ~12 min android 📦apk 📲
✔️ 6c842dc #16 2021-07-23 18:03:47 ~14 min android-e2e 📦apk 📲
✔️ 6c842dc #17 2021-07-23 18:07:37 ~18 min ios 📦ipa 📲

@briansztamfater briansztamfater force-pushed the feature/mention-activity-center branch 2 times, most recently from 234d744 to af9461d Compare July 2, 2021 19:42
Base automatically changed from feature/mention-activity-center to develop July 2, 2021 19:42
@briansztamfater briansztamfater force-pushed the feature/reply-activity-center branch 4 times, most recently from bd92d08 to 5ed1716 Compare July 8, 2021 20:44
@briansztamfater briansztamfater changed the title [WIP] Show replies in activity center Show replies in activity center Jul 8, 2021
@briansztamfater briansztamfater marked this pull request as ready for review July 8, 2021 20:50
@briansztamfater briansztamfater changed the title Show replies in activity center 📝 Show replies in activity center Jul 8, 2021
shivekkhurana
shivekkhurana approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@shivekkhurana shivekkhurana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can update the styles to use quo.design-system.spacing. Looks good otherwise.

src/status_im/ui/screens/notifications_center/styles.cljs Outdated
:margin-top 6
:margin-bottom 10
:margin-right 15
:padding-left 5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The odd numbers look odd. Have you looked at spacing namespace?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a look at it!

@status-im-auto
Copy link
Member

86% of end-end tests have passed

Total executed tests: 71
Failed tests: 10
Passed tests: 61

IDs of failed tests: 6305,5412,695843,6251,5360,6228,5379,6646,6237,6290

Failed tests (10)

Click to expand
  • Rerun tests

    • 1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305

    Device 2: =========================================================================
    Device 2: *Find Button by accessibility id:* `message-image`

    Device 2: Button by accessibility id: `message-image` is not found on the screen

    Device sessions

    2. test_insufficient_funds_wallet_positive_balance, id: 5412

    Device 1: *Getting STT amount*
    Device 1: *Scrolling down to SilentButton*

    Device 1: SilentButton by xpath:* `//android.view.ViewGroup[@content-desc=':STT-asset-value']//android.widget.TextView[1]` is not found on the screen

    Device sessions

    3. test_edit_message_in_one_to_one_and_public_chats, id: 695843

    Device 2: =========================================================================
    Device 1: *Find Button by xpath:* `//*[contains(@text, "AFTER")]`

    Device 1: Button by xpath: `//*[contains(@text, "AFTER")]` is not found on the screen

    Device sessions

    4. test_keycard_sign_message_and_transactions_from_daap, id: 6251

    Device 1: *Find SignWithKeycardButton by xpath:* `//*[contains(@text,'Sign with')]`
    Device 1: **Enter default pin 111111**

    Device 1: Transaction failed; also Unexpected Alert is shown: 'nonce too low'

    Device sessions

    5. test_unread_messages_counter_public_chat, id: 5360

    Device 2: **Signed in successfully!**
    Device 2: **Looking for chat '#qkmbgtn'**

    Counter is not shown for mention in public chat

    Device sessions

    6. test_mobile_data_usage_complex_settings, id: 6228

    Device 1: *Find Button by xpath:* `//*[@text="Use mobile data"]/following-sibling::android.widget.Switch[1]`
    Device 1: *Find Button by xpath:* `//*[@text="Ask me when on mobile network"]/following-sibling::android.widget.Switch[1]`

    Chat history was not fetched with mobile data fetching ON

    Device sessions

    7. test_home_view, id: 5379

    Device 1: *Find Button by xpath:* `//*[@text="Get started"]`
    Device 1: *Tap on found Button*

    Device 1: Unable to find multiaccount by position 4

    Device sessions

    8. test_set_profile_picture, id: 6646

    Device 1: *Find Button by xpath:* `//*[@text="DCIM"]`
    Device 1: *Tap on found Button*

    Device 1: 'SilentButton' by xpath:'//*[contains(@content-desc,'sauce_logo.png')]' not found on the screen

    Device sessions

    9. test_fetching_balance_after_offline, id: 6237

    Device 1: EditBox element not found
    Device 1: *Find EditBox by accessibility id:* `enter-password-input`

    Device 1: EditBox by accessibility id: `enter-password-input` is not found on the screen

    Device sessions

    10. test_keycard_fetching_balance_after_offline, id: 6290

    Transaction #5, amount is 0.000770931
    {'blockNumber': '10600237', 'timeStamp': '1625811144', 'hash': '0xb87f19e990a3852f59478ffb74a46ddbd57313eec2096fcd3d0808e9a50ac016', 'nonce': '1282', 'blockHash': '0xa2c7cc6dd5700354f48f6fbdfaddf96d57d3e477dd8cb8af07b00d387fbc76c9', 'from': '0x0f3eff5cacee63045be97281316457fb78dd659e', 'contractAddress': '0x101848d5c5bbca18e6b4431eedf6b95e9adf82fa', 'to': '0xf184747445c3b85ceb147dfb136067cb93d95f1d', 'value': '770931000000000', 'tokenName': 'Weenus 💪', 'tokenSymbol': 'WEENUS', 'tokenDecimal': '18', 'transactionIndex': '0', 'gas': '41362', 'gasPrice': '32000000000', 'gasUsed': '34469', 'cumulativeGasUsed': '34469', 'input': 'deprecated', 'confirmations': '1246'}

    Transaction with amount 0.009104549 is not found in list of token transactions, address is f184747445c3B85CEb147DfB136067CB93d95F1D during 300s

    Device sessions

    Passed tests (61)

    Click to expand

    1. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    2. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    3. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    4. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    5. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    6. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    7. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    8. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    9. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    10. test_keycard_create_login_resotore_unlock_same_seed, id: 5689
    Device sessions

    11. test_delete_close_all_tabs, id: 5390
    Device sessions

    12. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    13. test_send_token_with_7_decimals, id: 5350
    Device sessions

    14. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    15. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    16. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    17. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    18. test_block_user_from_public_chat, id: 5786
    Device sessions

    19. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    20. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
    Device sessions

    21. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    22. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    23. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    24. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    25. test_back_forward_refresh_navigation_history_kept_after_relogin (TestRail link is not found)
    Device sessions

    26. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    27. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    28. test_long_press_to_delete_chat, id: 5319
    Device sessions

    29. test_copy_and_paste_messages, id: 5317
    Device sessions

    30. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    31. test_user_can_see_all_own_assets_after_account_recovering, id: 5381
    Device sessions

    32. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    33. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    34. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    35. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    36. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    37. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    38. test_manage_assets, id: 5341
    Device sessions

    39. test_browser_managing_bookmarks, id: 6633
    Device sessions

    40. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    41. test_request_stt_from_daap, id: 5309
    Device sessions

    42. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    43. test_dapps_permissions, id: 5738
    Device sessions

    44. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    45. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    46. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    47. test_wallet_set_up, id: 5335
    Device sessions

    48. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    49. test_can_add_existing_ens, id: 5502
    Device sessions

    50. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    51. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    52. test_collectible_from_wallet, id: 5346
    Device sessions

    53. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    54. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    55. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    56. test_pass_phrase_validation, id: 5363
    Device sessions

    57. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    58. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    59. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    60. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    61. test_public_chat_messaging_emojis_timestamps, id: 5313
    Device sessions

    @briansztamfater briansztamfater mentioned this pull request Jul 9, 2021
    Merged
    @qoqobolo qoqobolo self-assigned this Jul 13, 2021
    @qoqobolo
    Copy link
    Contributor

    qoqobolo commented Jul 13, 2021 •
    edited
    Loading

    @briansztamfater thanks for your work!

    ISSUE 1: Replies in Activity center aren't shown on iOS

    Steps:

    1. UserA adds UserB (iOS-user) to contacts and creates a group chat (or community)
    2. UserB joins the group, sends a message, and navigates to Home screen
    3. UserA sends a reply to UserB
    4. UserB opens Activity center
      Expected result: notification for the reply on Activity center screen
      Actual result: unread indicator on the bell is shown but Activity center is empty

    Also, the unread indicator appears on the bell only for the first received reply. For further replies, only the unread message indicator on the chat is displayed. Sometimes notifications for mentions stop displaying in the activity center as well. To start receiving them again, you need to get a mention while on the Activity Center screen.

    IMG_0777.mp4

    ISSUE 2: Black font of reply in Activity center

    The issue is relevant for several types of messages and is reproducible in develop: #12274
    But if it's not very difficult to fix (and if it's really a regression after Mention notifications in Activity center), maybe you would like to do it in this PR :)

    Screenshot 2021-07-13 at 11 51 51

    @briansztamfater
    Copy link
    Member Author

    @qoqobolo thanks for the testing, I'm looking at those issues right now.

    @briansztamfater
    Copy link
    Member Author

    @qoqobolo Issues should be addressed, let me know how testing goes :)

    @qoqobolo
    Copy link
    Contributor

    qoqobolo commented Jul 14, 2021 •
    edited
    Loading

    @briansztamfater thanks, issues 1 and 2 are fixed.

    ISSUE 3: Error and further inability to open Activity center when receiving a specific message in 1-1, group chat, or community

    If copy a text from an external website containing an image (e.g. from Wikipedia), which will appear as obj when pasted into a message, and send contact request in 1-1 chat/reply/mention in a group or community with this object, then the receiver will get Error: invalid arity when trying to open Activity center.
    After that, in most cases, Activity center cannot be opened, even after reopening the application.

    Reproduction:

    UserA:

    1. Add UserB to contacts
    2. Open some website, e.g. wikipedia, and copy some piece of text containing an image, like this:

    Screenshot 2021-07-14 at 16 19 25

    1. Start 1-1 chat with UserB, paste the copied text (NOT as plain text), and send the message

    UserB:

    1. Open Activity center

    Actual result

    Screenshot 2021-07-14 at 14 41 40

    OS: Android, iOS
    Tried to reproduce in develop, but no success.

    ISSUE 4: Double @ when receiving a reply to a message containing mention of ENS user

    Screenshot 2021-07-14 at 16 40 22

    Reproduction:
    UserA and UserB are members of the same group chat
    UserB has ENS

    UserA:

    • Send a mention of UserB
    • Navigate to Activity center

    UserB:

    • Open the group
    • Reply to the mention

    UserA:

    • Check a new notification in Activity center

    @briansztamfater
    Copy link
    Member Author

    briansztamfater commented Jul 14, 2021 •
    edited
    Loading

    @qoqobolo Thanks for rising these issues, both should be fixed now!

    @status-im-auto
    Copy link
    Member

    96% of end-end tests have passed

    Total executed tests: 71
Failed tests: 3
Passed tests: 68

    IDs of failed tests: 6253,6237,6290

    Failed tests (3)

    Click to expand
  • Rerun tests

    • 1. test_send_eth_in_1_1_chat_transaction_push, id: 6253

    Device 1: *Tap on found Button*
    Device 1: *Find GasPriceInput by xpath:* `(//*[@text="Gas limit"]/..//android.widget.EditText)[2]`

    Device 1: GasPriceInput by xpath: `(//*[@text="Gas limit"]/..//android.widget.EditText)[2]` is not found on the screen

    Device sessions

    2. test_fetching_balance_after_offline, id: 6237

    Device 1: EditBox element not found
    Device 1: *Find EditBox by accessibility id:* `enter-password-input`

    Device 1: EditBox by accessibility id: `enter-password-input` is not found on the screen

    Device sessions

    3. test_keycard_fetching_balance_after_offline, id: 6290

    Transaction #5, amount is 6.771e-15
    {'blockNumber': '10640318', 'timeStamp': '1626335434', 'hash': '0x176e03cfc495a36df3d66edafacd296ad0b4476e5f890b29ccbf8da7c0f09bc5', 'nonce': '4122', 'blockHash': '0xb81ad55109deb18e3714ecbd3824308e8575fdae6df5ee64005bbef2a510fef9', 'from': '0x061fae3dd75beab5855f584837ca0c0a8e84f5c1', 'contractAddress': '0xe639e24346d646e927f323558e6e0031bfc93581', 'to': '0xf184747445c3b85ceb147dfb136067cb93d95f1d', 'value': '6771', 'tokenName': 'Adi Test Token', 'tokenSymbol': 'ADI', 'tokenDecimal': '7', 'transactionIndex': '1', 'gas': '41235', 'gasPrice': '32000000000', 'gasUsed': '34363', 'cumulativeGasUsed': '138694', 'input': 'deprecated', 'confirmations': '663'}

    Transaction with amount 0.0015101434 is not found in list of token transactions, address is f184747445c3B85CEb147DfB136067CB93d95F1D during 300s

    Device sessions

    Passed tests (68)

    Click to expand

    1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    2. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    3. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    4. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    5. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    6. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    7. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    8. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    9. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    10. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    11. test_keycard_create_login_resotore_unlock_same_seed, id: 5689
    Device sessions

    12. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    13. test_delete_close_all_tabs, id: 5390
    Device sessions

    14. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    15. test_send_token_with_7_decimals, id: 5350
    Device sessions

    16. test_edit_message_in_one_to_one_and_public_chats, id: 695843
    Device sessions

    17. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    18. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    19. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    20. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    21. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    22. test_block_user_from_public_chat, id: 5786
    Device sessions

    23. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    24. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
    Device sessions

    25. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    26. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    27. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    28. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    29. test_back_forward_refresh_navigation_history_kept_after_relogin (TestRail link is not found)
    Device sessions

    30. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    31. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    32. test_long_press_to_delete_chat, id: 5319
    Device sessions

    33. test_copy_and_paste_messages, id: 5317
    Device sessions

    34. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    35. test_unread_messages_counter_public_chat, id: 5360
    Device sessions

    36. test_user_can_see_all_own_assets_after_account_recovering, id: 5381
    Device sessions

    37. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    38. test_mobile_data_usage_complex_settings, id: 6228
    Device sessions

    39. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    40. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    41. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    42. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    43. test_manage_assets, id: 5341
    Device sessions

    44. test_browser_managing_bookmarks, id: 6633
    Device sessions

    45. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    46. test_request_stt_from_daap, id: 5309
    Device sessions

    47. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    48. test_dapps_permissions, id: 5738
    Device sessions

    49. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    50. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    51. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    52. test_wallet_set_up, id: 5335
    Device sessions

    53. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    54. test_home_view, id: 5379
    Device sessions

    55. test_can_add_existing_ens, id: 5502
    Device sessions

    56. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    57. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    58. test_set_profile_picture, id: 6646
    Device sessions

    59. test_collectible_from_wallet, id: 5346
    Device sessions

    60. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    61. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    62. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    63. test_pass_phrase_validation, id: 5363
    Device sessions

    64. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    65. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    66. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    67. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    68. test_public_chat_messaging_emojis_timestamps, id: 5313
    Device sessions

    @qoqobolo
    Copy link
    Contributor

    @briansztamfater awesome, thanks!
    No new issues were found, failed e2e are not related to PR.
    So let's merge!

    @briansztamfater
    Show replies on activity center
    6ee9f6a 
    Signed-off-by: Brian Sztamfater <brian@status.im>
    @briansztamfater briansztamfater merged commit 6ee9f6a into develop Jul 23, 2021
    @briansztamfater briansztamfater deleted the feature/reply-activity-center branch July 23, 2021 17:50
    @qoqobolo qoqobolo mentioned this pull request Jul 26, 2021
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @flexsurfer flexsurfer flexsurfer approved these changes

    @shivekkhurana shivekkhurana shivekkhurana approved these changes

    Assignees

    @briansztamfater briansztamfater

    @qoqobolo qoqobolo

    Labels
    activity-center request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    Release 1.15
    Development

    Successfully merging this pull request may close these issues.

    Show replies in activity center
    5 participants
    @briansztamfater @status-im-auto @qoqobolo @shivekkhurana @flexsurfer