[#10041] Request token price after adding #10043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (3)
|
yenda
approved these changes
Feb 14, 2020
| "from" from | ||
| "to" to | ||
| "mainnet?" mainnet? | ||
| "chaos-mode?" chaos-mode?) |
There was a problem hiding this comment.
didn't we remove chaos-mode?
There was a problem hiding this comment.
I have no idea, it is at least in this function
There was a problem hiding this comment.
@yenda as far as I see it is still in the project
There was a problem hiding this comment.
i just disabled it, not removed, but dunno if we want to remove all related code completely
|
@rasom related bug, when we remove token we don't recalculate total value in fiat, probably could be done in this PR ? |
flexsurfer
approved these changes
Feb 14, 2020
rasom
force-pushed
the
fix/new-token-price-#10041
branch
from
9c91f8b
to
abeee10
Compare
rasom
force-pushed
the
fix/new-token-price-#10041
branch
from
abeee10
to
965dce0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #10041
status: ready