test_: Code Migration from status-cli-tests with create private groups #6028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Jenkins BuildsClick to see older builds (16)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## cli_test_migration #6028 +/- ##
======================================================
+ Coverage 59.99% 60.07% +0.08%
======================================================
Files 812 812
Lines 109328 109328
======================================================
+ Hits 65589 65683 +94
+ Misses 36015 35961 -54
+ Partials 7724 7684 -40
Flags with carried forward coverage won't be shown. Click here to find out more. |
fbarbu15
reviewed
Nov 7, 2024
Contributor
fbarbu15
left a comment
fbarbu15
left a comment
There was a problem hiding this comment.
Left some comments
Also let's not merge this one to the main branch until we sort the main PR
Thanks
| self.first_node.stop() | ||
| self.second_node.stop() | ||
|
|
||
| def send_and_wait_for_message(self, nodes, display_name, index, timeout=10): |
Contributor
There was a problem hiding this comment.
in this case we should just assume that contact_request works fine and the validation should focus on private_group functionality
|
|
||
| return timestamp, message_id, contact_request_message, response | ||
|
|
||
| def create_and_validate_private_group(self, node, members_pubkeys, group_name, timeout=10): |
Contributor
There was a problem hiding this comment.
we should extract those functions in some common place/helper so we don't duplicate it
| actual_contact_request_state = last_message.get("contactRequestState") | ||
| assert actual_contact_request_state == 1, ( | ||
| f"Unexpected contact request state: Expected '1', found '{actual_contact_request_state}'" | ||
| assert actual_contact_request_state >= 1, ( |
Contributor
There was a problem hiding this comment.
maybe we should add a new param and in some places to keep the assertion as exact and other places where we don't care that much to keep it as loose
Collaborator
|
This work was already done in other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
Added Test to create a private group
Migrated contract request test from the old repository https://github.com/status-im/status-cli-tests
Added response validation
Helper and methods to support migration