feat(e2e_appium): async test config and onboarding fixture

Author: glitchminer

test/e2e_appium/fixtures/onboarding_fixture.py

@@ -26,6 +26,7 @@
 from models.user_model import User, UserProfile
 from config import get_config
 from config.logging_config import get_logger
+from services.app_initialization_manager import AppInitializationManager
 
 
 @dataclass
@@ -148,22 +149,16 @@ def execute_complete_flow(self) -> Dict[str, Any]:
             else:
                 self._execute_analytics_skip_step()
 
-            # Step 3a: Create Profile Screen OR Step 3b: Seed Phrase Import
             if self.config.use_seed_phrase:
-                # Seed phrase import flow
                 self._execute_seed_phrase_import_step()
             else:
-                # New profile creation flow
                 if not self.config.skip_profile_creation:
                     self._execute_create_profile_step()
 
-            # Step 4: Password Creation
             self._execute_password_step()
 
-            # Step 5: Loading Screen
             self._execute_loading_step()
 
-            # Step 6: Main App Verification
             if self.config.verify_main_app:
                 self._execute_main_app_verification()
 
@@ -189,14 +184,18 @@ def _execute_welcome_step(self):
         self.current_step = "welcome_screen"
         self.logger.info("Step 1: Welcome Screen")
 
-        # Wait for screen to be fully loaded before activating accessibility
-        # Wait for app to be visually ready (look for any UI elements)
+        # Wait for session to be ready before checking for UI
+        try:
+            init_manager = AppInitializationManager(self.driver)
+            init_manager._wait_for_session_ready(timeout=5.0)
+        except Exception as exc:
+            self.logger.debug("Session readiness check skipped: %s", exc)
+
         max_wait = 10
         for attempt in range(max_wait):
             try:
-                # Check if any UI elements are present (even without accessibility)
                 elements = self.main_app_page.driver.find_elements("xpath", "//*")
-                if len(elements) > 5:  # Basic UI structure loaded
+                if len(elements) > 5:
                     break
                 time.sleep(1)
             except Exception:
@@ -206,10 +205,21 @@ def _execute_welcome_step(self):
             self.main_app_page.driver.tap([(500, 300)])  
             time.sleep(1)
         except Exception:
-            pass  # Non-critical if tap fails
+            self.logger.debug("Initial tap attempt skipped", exc_info=True)
 
         if self.config.validate_each_step:
-            assert self.welcome_page.is_screen_displayed(timeout=30), (
+            welcome_visible = False
+            for attempt in range(3):
+                if self.welcome_page.is_screen_displayed(timeout=10):
+                    welcome_visible = True
+                    break
+                if attempt < 2:
+                    self.logger.debug(
+                        f"Welcome screen not visible yet (attempt {attempt + 1}/3), waiting..."
+                    )
+                    time.sleep(2)
+            
+            assert welcome_visible, (
                 "Welcome screen should be displayed"
             )
 
@@ -224,7 +234,6 @@ def _execute_welcome_step(self):
             self._take_screenshot("welcome_completed")
 
     def _execute_seed_phrase_import_step(self):
-        """Execute seed phrase import from Create Profile screen into Password."""
         self.current_step = "seed_phrase_import"
         self.logger.info("Step 3: Seed Phrase Import")
 
@@ -257,7 +266,6 @@ def _execute_seed_phrase_import_step(self):
             self._take_screenshot("seed_phrase_import_completed")
 
     def _execute_analytics_step(self):
-        """Execute analytics screen interaction"""
         self.current_step = "analytics_screen"
         self.logger.info("Step 2: Analytics Screen (interacting)")
 
@@ -266,7 +274,6 @@ def _execute_analytics_step(self):
                 "Analytics screen should be displayed"
             )
 
-        # Interact with analytics consent (accept sharing)
         self.analytics_page.accept_analytics_sharing()
 
         self.step_results["analytics_screen"] = {
@@ -276,7 +283,6 @@ def _execute_analytics_step(self):
         }
 
     def _execute_analytics_skip_step(self):
-        """Execute analytics screen skip action"""
         self.current_step = "analytics_screen_skip"
         self.logger.info("Step 2: Analytics Screen (skipping)")
 
@@ -297,7 +303,6 @@ def _execute_analytics_skip_step(self):
             self._take_screenshot("analytics_skipped")
 
     def _execute_create_profile_step(self):
-        """Execute create profile screen interaction"""
         self.current_step = "create_profile_screen"
         self.logger.info("Step 3: Create Profile Screen")
 
@@ -317,7 +322,6 @@ def _execute_create_profile_step(self):
             self._take_screenshot("profile_created")
 
     def _execute_password_step(self):
-        """Execute password creation step"""
         self.current_step = "password_screen"
         self.logger.info("Step 4: Password Screen")
 

test/e2e_appium/pages/base_page.py

@@ -1,5 +1,6 @@
 import time
 import logging
+import os
 from datetime import datetime
 from pathlib import Path
 from typing import Optional, List

test/e2e_appium/pages/onboarding/loading_page.py

@@ -6,7 +6,12 @@
 
 from selenium.webdriver.support.ui import WebDriverWait
 from selenium.webdriver.support import expected_conditions as EC
-from selenium.common.exceptions import TimeoutException
+from selenium.common.exceptions import (
+    TimeoutException,
+    WebDriverException,
+    NoSuchWindowException,
+    InvalidSessionIdException,
+)
 
 from ..base_page import BasePage
 from locators.onboarding.loading_screen_locators import LoadingScreenLocators
@@ -34,6 +39,21 @@ def wait_for_loading_completion(self, timeout: int = 60) -> bool:
             )
             self.logger.info("Loading completed - screen disappeared")
             return True
+        except (NoSuchWindowException, InvalidSessionIdException) as e:
+            self.logger.error(
+                f"WebDriver session ended during loading wait: {type(e).__name__}: {e}"
+            )
+            return False
+        except WebDriverException as e:
+            self.logger.warning(
+                f"WebDriver error during loading wait: {type(e).__name__}: {e}"
+            )
+            try:
+                _ = self.driver.current_url
+            except (WebDriverException, InvalidSessionIdException, NoSuchWindowException):
+                self.logger.error("WebDriver session appears to be dead")
+                return False
+            return False
         except TimeoutException:
             self.logger.warning(
                 f"Loading did not complete within {timeout} seconds; checking main app state"

test/e2e_appium/pytest.ini

@@ -1,5 +1,7 @@
 [pytest]
-addopts = -v --tb=short --strict-markers
+addopts = -v --tb=short --strict-markers --timeout=600
+asyncio_mode = strict
+timeout = 600
 markers =
     smoke: Quick critical tests for PR validation
     onboarding: User onboarding flow tests
@@ -12,4 +14,7 @@ markers =
     onboarding_config: Custom configuration for onboarding fixture 
     messaging: Messaging tests 
     wallet: Wallet tests
-    saved_addresses: Saved addresses tests
+    saved_addresses: Saved addresses tests
+    no_autouse_onboarded: Skip automatic onboarding fixture for tests that manage their own onboarding
+    single_device: Tests that only require a single device (use device_count(1) marker)
+    asyncio: Async test marker (managed by pytest-asyncio)

test/e2e_appium/utils/exceptions.py

@@ -32,6 +32,12 @@ class SessionManagementError(Exception):
     pass
 
 
+class BrowserStackQueueError(SessionManagementError):
+    """Exception for BrowserStack queue exhaustion errors."""
+
+    pass
+
+
 class ElementInteractionError(Exception):
     """Exception for element interaction failures (clicks, input, etc.)."""