update libp2p branch when unstable changes #6202
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegomrsantos
force-pushed
the
update-libp2p-branch
branch
2 times, most recently
from
cb75ed2 to
efeb1c9
Compare
tersec
reviewed
Apr 18, 2024
arnetheduck
reviewed
May 1, 2024
| - name: Update libp2p branch | ||
| run: | | ||
| cd vendor/nim-libp2p | ||
| git checkout unstable |
There was a problem hiding this comment.
needs updating for the new naming scheme
|
Is this still relevant? We are still running Libp2p nodes but they are outdated and Holesky fork is today: I guess I can update the branch manually for now. |
|
Updated manually for today:
|
Co-authored-by: tersec <tersec@users.noreply.github.com>
tersec
force-pushed
the
update-libp2p-branch
branch
from
31f5a9a to
239dedf
Compare
etan-status
force-pushed
the
unstable
branch
2 times, most recently
from
a0510ce to
aa88cd4
Compare
|
ping @richard-ramos is this still relevant? |
|
in nim-libp2p we’ve got this workflow that bumps the autobump branch with the latest unstable from nimbus + latest master from nim-libp2p whenever something lands in nim-libp2p master. this new one looks basically the same but triggers on changes to nimbus unstable. not clear what extra value it adds, feels redundant since the existing one already covers the same ground from the nim-libp2p side, so i vote to close this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR automates updating the libp2p branch when the Nimbus unstable branch changes. The libp2p branch will contain the latest Nimbus and nim-libp2p unstable.