Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update libp2p branch when unstable changes #6202

Open
wants to merge 4 commits into
base: unstable
Choose a base branch
from
Open

update libp2p branch when unstable changes #6202

wants to merge 4 commits into from

Conversation

diegomrsantos
Copy link
Contributor

@diegomrsantos diegomrsantos commented Apr 12, 2024 •
edited
Loading

This PR automates updating the libp2p branch when the Nimbus unstable branch changes. The libp2p branch will contain the latest Nimbus and nim-libp2p unstable.

@diegomrsantos diegomrsantos force-pushed the update-libp2p-branch branch 2 times, most recently from cb75ed2 to efeb1c9 Compare April 12, 2024 11:30
@diegomrsantos diegomrsantos marked this pull request as ready for review April 12, 2024 11:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 12, 2024 •
edited
Loading

Unit Test Results

       15 files  ±0    2 630 suites  ±0   1h 22m 54s ⏱️ + 8m 33s
  6 436 tests ±0    5 915 ✔️ ±0  521 💤 ±0  0 ❌ ±0 
44 766 runs  ±0  44 048 ✔️ ±0  718 💤 ±0  0 ❌ ±0 

Results for commit 239dedf. ± Comparison against base commit 23430ff.

♻️ This comment has been updated with latest results.

@melindadavis666 melindadavis666 mentioned this pull request Apr 18, 2024
Open
arnetheduck
arnetheduck reviewed May 1, 2024
View reviewed changes
.github/workflows/update-libp2p-branch.yml Outdated
- name: Update libp2p branch
run: |
cd vendor/nim-libp2p
git checkout unstable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs updating for the new naming scheme

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jakubgs
Copy link
Member

jakubgs commented Feb 24, 2025

Is this still relevant? We are still running Libp2p nodes but they are outdated and Holesky fork is today:

geth-01.ih-eu-mda1.nimbus.holesky | CHANGED | rc=0 | (stdout) Nimbus/v24.12.0-daf984-stateofus
geth-02.ih-eu-mda1.nimbus.holesky | CHANGED | rc=0 | (stdout) Nimbus/v24.12.0-daf984-stateofus
geth-03.ih-eu-mda1.nimbus.holesky | CHANGED | rc=0 | (stdout) Nimbus/v24.12.0-daf984-stateofus
geth-04.ih-eu-mda1.nimbus.holesky | CHANGED | rc=0 | (stdout) Nimbus/v24.12.0-daf984-stateofus
geth-05.ih-eu-mda1.nimbus.holesky | CHANGED | rc=0 | (stdout) Nimbus/v24.12.0-daf984-stateofus
geth-06.ih-eu-mda1.nimbus.holesky | CHANGED | rc=0 | (stdout) Nimbus/v24.12.0-daf984-stateofus
geth-07.ih-eu-mda1.nimbus.holesky | CHANGED | rc=0 | (stdout) Nimbus/v24.12.0-daf984-stateofus
geth-08.ih-eu-mda1.nimbus.holesky | CHANGED | rc=0 | (stdout) Nimbus/v24.12.0-daf984-stateofus
geth-09.ih-eu-mda1.nimbus.holesky | CHANGED | rc=0 | (stdout) Nimbus/v24.12.0-daf984-stateofus
geth-10.ih-eu-mda1.nimbus.holesky | CHANGED | rc=0 | (stdout) Nimbus/v24.12.0-daf984-stateofus

I guess I can update the branch manually for now.

@jakubgs
Copy link
Member

jakubgs commented Feb 24, 2025

Updated manually for today:

@tersec tersec force-pushed the update-libp2p-branch branch from 31f5a9a to 239dedf Compare March 27, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnetheduck arnetheduck arnetheduck left review comments

@tersec tersec tersec left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@diegomrsantos @jakubgs @arnetheduck @tersec