supernodes to da on NUMBER_OF_COLUMNS div 2

Author: agnxsh

beacon_chain/consensus_object_pools/blob_quarantine.nim

@@ -460,7 +460,7 @@ func hasSidecars*(
     supernode = (len(quarantine.custodyColumns) == NUMBER_OF_COLUMNS)
     columnsCount =
       if supernode:
-        (NUMBER_OF_COLUMNS div 2 + 1)
+        NUMBER_OF_COLUMNS div 2
       else:
         len(quarantine.custodyColumns)
 
@@ -546,7 +546,7 @@ proc popSidecars*(
     supernode = (len(quarantine.custodyColumns) == NUMBER_OF_COLUMNS)
     columnsCount =
       if supernode:
-        (NUMBER_OF_COLUMNS div 2 + 1)
+        NUMBER_OF_COLUMNS div 2
       else:
         len(quarantine.custodyColumns)
 
@@ -567,10 +567,10 @@ proc popSidecars*(
           "Record should only have loaded values, but it is `" &
             $sidecar.kind & "`")
         sidecars.add(sidecar.data)
-      if len(sidecars) >= (NUMBER_OF_COLUMNS div 2 + 1):
+      if len(sidecars) >= NUMBER_OF_COLUMNS div 2:
         break
 
-    doAssert(len(sidecars) >= (NUMBER_OF_COLUMNS div 2 + 1),
+    doAssert(len(sidecars) >= NUMBER_OF_COLUMNS div 2,
       "Incorrect amount of sidecars in record for supernode - " &
         $len(sidecars))
   else:

tests/test_column_map.nim

@@ -103,7 +103,7 @@ suite "ColumnMap test suite":
           vector[2]
 
   test "supernode test":
-    for max in ((NUMBER_OF_COLUMNS div 2) + 1) ..< NUMBER_OF_COLUMNS:
+    for max in (NUMBER_OF_COLUMNS div 2) ..< NUMBER_OF_COLUMNS:
       var columns: seq[ColumnIndex]
       for i in 0 ..< max:
         columns.add(ColumnIndex(i))