Simplify getMissingSidecarIndices(columns).

Author: cheatfate

beacon_chain/consensus_object_pools/blob_quarantine.nim

@@ -728,26 +728,18 @@ func getMissingSidecarIndices*(
     # Fast-path if block does not have any columns
     return res
 
-  let supernode = (len(quarantine.custodyColumns) == NUMBER_OF_COLUMNS)
-  if supernode:
+  if (len(quarantine.custodyColumns) == NUMBER_OF_COLUMNS):
     if len(record.sidecars) > NUMBER_OF_COLUMNS div 2:
       return res
-    if len(record.sidecars) == 0:
-      for index in 0 ..< NUMBER_OF_COLUMNS:
+    for index in 0 ..< NUMBER_OF_COLUMNS:
+      if (len(record.sidecars) == 0) or record.sidecars[index].isEmpty():
         res.add(ColumnIndex(index))
-    else:
-      for index in 0 ..< NUMBER_OF_COLUMNS:
-        if record.sidecars[index].isEmpty():
-          res.add(ColumnIndex(index))
   else:
-    if len(record.sidecars) == 0:
-      for column in quarantine.custodyMap.items():
+    for column in quarantine.custodyMap.items():
+      let index = quarantine.getIndex(column)
+      if (len(record.sidecars) == 0) or (index == -1) or
+         record.sidecars[index].isEmpty():
         res.add(column)
-    else:
-      for column in quarantine.custodyMap.items():
-        let index = quarantine.getIndex(column)
-        if (index == -1) or (record.sidecars[index].isEmpty()):
-          res.add(column)
   res
 
 proc pruneAfterFinalization*(