Cache rocksdb binary in CI (#3535)

jangko · web-flow · commit 517b1d03a217 · 2025-08-03T14:56:44.000+07:00
* Cache rocksdb binary in CI

* fix portal.yml

* Bump rocksdb

* bump rocksdb
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -137,12 +137,13 @@ jobs:
           runner.os == 'Windows'
         run: |
           mkdir -p external
-          MINGW_BASE="https://github.com/mstorsjo/llvm-mingw/releases/download/20230905"
+          LLVM_VERSION="20250730"
+          MINGW_BASE="https://github.com/mstorsjo/llvm-mingw/releases/download/$LLVM_VERSION"
           if [[ '${{ matrix.target.cpu }}' == 'amd64' ]]; then
-            MINGW_URL="$MINGW_BASE/llvm-mingw-20230905-ucrt-x86_64.zip"
+            MINGW_URL="$MINGW_BASE/llvm-mingw-$LLVM_VERSION-ucrt-x86_64.zip"
             ARCH=64
           else
-            MINGW_URL="$MINGW_BASE/llvm-mingw-20230905-ucrt-i686.zip"
+            MINGW_URL="$MINGW_BASE/llvm-mingw-$LLVM_VERSION-ucrt-i686.zip"
             ARCH=32
           fi
           curl -L "$MINGW_URL" -o "external/mingw-${{ matrix.target.cpu }}.zip"
@@ -171,6 +172,22 @@ jobs:
           path: NimBinCache
           key: 'nim-${{ matrix.target.os }}-${{ matrix.target.cpu }}-${{ steps.versions.outputs.nimbus_build_system }}'
 
+      - name: Get latest nim-rocksdb commit hash
+        id: rocksdb-versions
+        run: |
+          getHash() {
+            git ls-remote "https://github.com/$1" "${2:-HEAD}" | cut -f 1
+          }
+          rocksHash=$(getHash status-im/nim-rocksdb)
+          echo "nim_rocksdb=$rocksHash" >> $GITHUB_OUTPUT
+
+      - name: Restore prebuilt rocksdb from cache
+        id: rocksdb-cache
+        uses: actions/cache@v4
+        with:
+          path: RocksBinCache
+          key: 'rocks-${{ matrix.target.os }}-${{ matrix.target.cpu }}-${{ steps.rocksdb-versions.outputs.nim_rocksdb }}'
+
       - name: Build Nim and Nimbus-eth1 dependencies
         run: |
           make -j${ncpu} ARCH_OVERRIDE=${PLATFORM} CI_CACHE=NimBinCache init
@@ -179,7 +196,7 @@ jobs:
         if: runner.os == 'Windows'
         run: |
           gcc --version
-          DEFAULT_MAKE_FLAGS="-j${ncpu} ENABLE_VMLOWMEM=${ENABLE_VMLOWMEM}"
+          DEFAULT_MAKE_FLAGS="-j${ncpu} ENABLE_VMLOWMEM=${ENABLE_VMLOWMEM} ROCKSDB_CI_CACHE=RocksBinCache"
           mingw32-make ${DEFAULT_MAKE_FLAGS} all test_import build_fuzzers
           build/nimbus_execution_client.exe --help
           # give us more space
@@ -191,7 +208,7 @@ jobs:
         if: runner.os == 'Linux'
         run: |
           export LD_LIBRARY_PATH="${LD_LIBRARY_PATH}:/usr/local/lib"
-          DEFAULT_MAKE_FLAGS="-j${ncpu}"
+          DEFAULT_MAKE_FLAGS="-j${ncpu} ROCKSDB_CI_CACHE=RocksBinCache"
           env CC=gcc make ${DEFAULT_MAKE_FLAGS} all test_import build_fuzzers
           build/nimbus_execution_client --help
           # CC, GOARCH, and CGO_ENABLED are needed to select correct compiler 32/64 bit
@@ -206,7 +223,7 @@ jobs:
         if: runner.os == 'Macos'
         run: |
           export ZERO_AR_DATE=1 # avoid timestamps in binaries
-          DEFAULT_MAKE_FLAGS="-j${ncpu}"
+          DEFAULT_MAKE_FLAGS="-j${ncpu} ROCKSDB_CI_CACHE=RocksBinCache"
           make ${DEFAULT_MAKE_FLAGS} all test_import build_fuzzers
           build/nimbus_execution_client --help
           # "-static" option will not work for osx unless static system libraries are provided
diff --git a/.github/workflows/nimbus_verified_proxy.yml b/.github/workflows/nimbus_verified_proxy.yml
@@ -141,12 +141,13 @@ jobs:
           runner.os == 'Windows'
         run: |
           mkdir -p external
-          MINGW_BASE="https://github.com/mstorsjo/llvm-mingw/releases/download/20230905"
+          LLVM_VERSION="20250730"
+          MINGW_BASE="https://github.com/mstorsjo/llvm-mingw/releases/download/$LLVM_VERSION"
           if [[ '${{ matrix.target.cpu }}' == 'amd64' ]]; then
-            MINGW_URL="$MINGW_BASE/llvm-mingw-20230905-ucrt-x86_64.zip"
+            MINGW_URL="$MINGW_BASE/llvm-mingw-$LLVM_VERSION-ucrt-x86_64.zip"
             ARCH=64
           else
-            MINGW_URL="$MINGW_BASE/llvm-mingw-20230905-ucrt-i686.zip"
+            MINGW_URL="$MINGW_BASE/llvm-mingw-$LLVM_VERSION-ucrt-i686.zip"
             ARCH=32
           fi
           curl -L "$MINGW_URL" -o "external/mingw-${{ matrix.target.cpu }}.zip"
diff --git a/.github/workflows/portal.yml b/.github/workflows/portal.yml
@@ -33,6 +33,8 @@ on:
       - 'Makefile'
       - 'nimbus.nimble'
 
+  workflow_dispatch:
+
 jobs:
   # separate job so it can run concurrently with other tests
   testutp:
@@ -210,12 +212,13 @@ jobs:
           runner.os == 'Windows'
         run: |
           mkdir -p external
-          MINGW_BASE="https://github.com/mstorsjo/llvm-mingw/releases/download/20230905"
+          LLVM_VERSION="20250730"
+          MINGW_BASE="https://github.com/mstorsjo/llvm-mingw/releases/download/$LLVM_VERSION"
           if [[ '${{ matrix.target.cpu }}' == 'amd64' ]]; then
-            MINGW_URL="$MINGW_BASE/llvm-mingw-20230905-ucrt-x86_64.zip"
+            MINGW_URL="$MINGW_BASE/llvm-mingw-$LLVM_VERSION-ucrt-x86_64.zip"
             ARCH=64
           else
-            MINGW_URL="$MINGW_BASE/llvm-mingw-20230905-ucrt-x86_64.zip"
+            MINGW_URL="$MINGW_BASE/llvm-mingw-$LLVM_VERSION-ucrt-x86_64.zip"
             ARCH=32
           fi
           curl -L "$MINGW_URL" -o "external/mingw-${{ matrix.target.cpu }}.zip"
@@ -244,6 +247,22 @@ jobs:
           path: NimBinaries
           key: 'nim-${{ matrix.target.os }}-${{ matrix.target.cpu }}-${{ steps.versions.outputs.nimbus_build_system }}-portal'
 
+      - name: Get latest nim-rocksdb commit hash
+        id: rocksdb-versions
+        run: |
+          getHash() {
+            git ls-remote "https://github.com/$1" "${2:-HEAD}" | cut -f 1
+          }
+          rocksHash=$(getHash status-im/nim-rocksdb)
+          echo "nim_rocksdb=$rocksHash" >> $GITHUB_OUTPUT
+
+      - name: Restore prebuilt rocksdb from cache
+        id: rocksdb-cache
+        uses: actions/cache@v4
+        with:
+          path: RocksBinCache
+          key: 'rocks-${{ matrix.target.os }}-${{ matrix.target.cpu }}-${{ steps.rocksdb-versions.outputs.nim_rocksdb }}'
+
       - name: Build Nim and Nimbus-eth1 dependencies
         run: |
           # use CC to make sure Nim compiler and subsequent test
@@ -254,15 +273,15 @@ jobs:
         if: runner.os == 'Windows'
         run: |
           gcc --version
-          DEFAULT_MAKE_FLAGS="-j1"
+          DEFAULT_MAKE_FLAGS="-j${ncpu} ROCKSDB_CI_CACHE=RocksBinCache"
           mingw32-make ${DEFAULT_MAKE_FLAGS} nimbus_portal_client
           build/nimbus_portal_client.exe --help
-          find . -type d -name ".git" -exec rm -rf {} +
-          rm -rf nimcache
+          # find . -type d -name ".git" -exec rm -rf {} +
+          find . -type d -name "nimcache" -exec rm -rf {} +
           mingw32-make ${DEFAULT_MAKE_FLAGS} portal-tools
-          rm -rf nimcache
-          mingw32-make portal-test
-          rm -rf nimcache
+          find . -type d -name "nimcache" -exec rm -rf {} +
+          mingw32-make ${DEFAULT_MAKE_FLAGS} portal-test
+          find . -type d -name "nimcache" -exec rm -rf {} +
 
       - name: Run Nimbus Portal tests (Linux)
         if: runner.os == 'Linux'
@@ -271,22 +290,22 @@ jobs:
           ./env.sh nim -v
           ldd --version
           export LD_LIBRARY_PATH="${LD_LIBRARY_PATH}:/usr/local/lib"
-          DEFAULT_MAKE_FLAGS="-j${ncpu}"
+          DEFAULT_MAKE_FLAGS="-j${ncpu} ROCKSDB_CI_CACHE=RocksBinCache"
           env CC=gcc make ${DEFAULT_MAKE_FLAGS} nimbus_portal_client
           build/nimbus_portal_client --help
           env CC=gcc make ${DEFAULT_MAKE_FLAGS} portal-tools
           # CC is needed to select correct compiler 32/64 bit
-          env CC=gcc CXX=g++ make portal-test
+          env CC=gcc CXX=g++ make ${DEFAULT_MAKE_FLAGS} portal-test
 
       - name: Run Nimbus Portal tests (Macos)
         if: runner.os == 'Macos'
         run: |
-          DEFAULT_MAKE_FLAGS="-j${ncpu}"
+          DEFAULT_MAKE_FLAGS="-j${ncpu} ROCKSDB_CI_CACHE=RocksBinCache"
           make ${DEFAULT_MAKE_FLAGS} nimbus_portal_client
           build/nimbus_portal_client --help
           make ${DEFAULT_MAKE_FLAGS} portal-tools
           # "-static" option will not work for osx unless static system libraries are provided
-          make portal-test
+          make ${DEFAULT_MAKE_FLAGS} portal-test
 
       - name: Run Portal testnet
         run: |
diff --git a/.github/workflows/simulators.yml b/.github/workflows/simulators.yml
@@ -54,15 +54,6 @@ jobs:
         run: |
           sudo apt-get -q update
 
-      - name: Get latest nimbus-build-system commit hash
-        id: versions
-        run: |
-          getHash() {
-            git ls-remote "https://github.com/$1" "${2:-HEAD}" | cut -f 1
-          }
-          nbsHash=$(getHash status-im/nimbus-build-system)
-          echo "nimbus_build_system=$nbsHash" >> $GITHUB_OUTPUT
-
       - name: Restore llvm-mingw from cache
         if: runner.os == 'windows'
         id: windows-mingw-cache
@@ -89,12 +80,37 @@ jobs:
         run: |
           echo '${{ github.workspace }}'"/external/mingw-amd64/bin" >> $GITHUB_PATH
 
+      - name: Get latest nimbus-build-system commit hash
+        id: versions
+        run: |
+          getHash() {
+            git ls-remote "https://github.com/$1" "${2:-HEAD}" | cut -f 1
+          }
+          nbsHash=$(getHash status-im/nimbus-build-system)
+          echo "nimbus_build_system=$nbsHash" >> $GITHUB_OUTPUT
+
       - name: Restore prebuilt Nim from cache
         uses: actions/cache@v4
         with:
           path: NimBinaries
           key: 'nim-${{ matrix.target.os }}-${{ matrix.target.cpu }}-${{ steps.versions.outputs.nimbus_build_system }}-sim'
 
+      - name: Get latest nim-rocksdb commit hash
+        id: rocksdb-versions
+        run: |
+          getHash() {
+            git ls-remote "https://github.com/$1" "${2:-HEAD}" | cut -f 1
+          }
+          rocksHash=$(getHash status-im/nim-rocksdb)
+          echo "nim_rocksdb=$rocksHash" >> $GITHUB_OUTPUT
+
+      - name: Restore prebuilt rocksdb from cache
+        id: rocksdb-cache
+        uses: actions/cache@v4
+        with:
+          path: RocksBinCache
+          key: 'rocks-${{ matrix.target.os }}-${{ matrix.target.cpu }}-${{ steps.rocksdb-versions.outputs.nim_rocksdb }}'
+
       - name: Build Nim and deps
         run: |
           if [[ '${{ matrix.target.os }}' == 'windows' ]]; then
@@ -105,7 +121,7 @@ jobs:
             ncpu=$(nproc)
           fi
           make -j${ncpu} ARCH_OVERRIDE=x64 CI_CACHE=NimBinaries init
-          make -j${ncpu} deps rocksdb
+          make -j${ncpu} ROCKSDB_CI_CACHE=RocksBinCache deps rocksdb
 
       - name: Run Simulators
         run: |
@@ -139,11 +155,10 @@ jobs:
           cat windows_amd64_stat/* >> stat_notes.md
 
       - name: Delete tag
-        uses: dev-drprasad/delete-tag-and-release@v1.0.1
-        with:
-          delete_release: true
-          tag_name: sim-stat
-          github_token: ${{ secrets.GITHUB_TOKEN }}
+        run: gh release delete $TAG --cleanup-tag
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          TAG: sim-stat
 
       - name: Simulators results
         uses: ncipollo/release-action@v1
@@ -156,7 +171,7 @@ jobs:
           bodyFile: "stat_notes.md"
 
       - name: Delete artefacts
-        uses: geekyeggo/delete-artifact@v2
+        uses: geekyeggo/delete-artifact@v5
         with:
           failOnError: false
           name: |
diff --git a/Makefile b/Makefile
@@ -223,16 +223,12 @@ libbacktrace:
 	+ $(MAKE) -C vendor/nim-libbacktrace --no-print-directory BUILD_CXX_LIB=0
 
 # nim-rocksdb
+ROCKSDB_CI_CACHE :=
 
 ifneq ($(USE_SYSTEM_ROCKSDB), 0)
-ifeq ($(OS), Windows_NT)
 rocksdb:
-	+ vendor/nim-rocksdb/scripts/build_dlls_windows.bat && \
-	cp -a vendor/nim-rocksdb/build/librocksdb.dll build
-else
-rocksdb:
-	+ vendor/nim-rocksdb/scripts/build_static_deps.sh
-endif
+	+ MAKE="$(MAKE)" \
+		scripts/rocksdb_ci_cache.sh $(ROCKSDB_CI_CACHE)
 else
 rocksdb:
 endif
diff --git a/scripts/rocksdb_ci_cache.sh b/scripts/rocksdb_ci_cache.sh
@@ -0,0 +1,50 @@
+#!/usr/bin/env bash
+
+# Copyright (c) 2018-2025 Status Research & Development GmbH. Licensed under
+# either of:
+# - Apache License, version 2.0
+# - MIT license
+# at your option. This file may not be copied, modified, or distributed except
+# according to those terms.
+
+set -e
+
+# script arguments
+[[ $# -ne 1 ]] && { echo "Usage: $0 rocksdb_cache_dir"; }
+ROCKSDB_CACHE="$1"
+
+cd "$(dirname "${BASH_SOURCE[0]}")"/..
+
+REPO_DIR="${PWD}"
+BUILD_DEST="${REPO_DIR}/vendor/nim-rocksdb/build"
+
+: "${MAKE:=make}"
+
+# Windows detection
+if uname | grep -qiE "mingw|msys"; then
+  ON_WINDOWS=1
+else
+  ON_WINDOWS=0
+fi
+
+# Copy files from ci cache folder
+if [[ -n "$ROCKSDB_CI_CACHE" && -d "$ROCKSDB_CI_CACHE" ]]; then
+  mkdir -p ${BUILD_DEST}
+  cp -a "$ROCKSDB_CI_CACHE"/* "$BUILD_DEST"/ || true # let this one fail with an empty cache dir
+fi
+
+# This scripts has it's own logic to detect rebuilt or not
+if [[ "$ON_WINDOWS" == "0" ]]; then
+  MAKE="${MAKE}" ${REPO_DIR}/vendor/nim-rocksdb/scripts/build_static_deps.sh
+else
+  MAKE="${MAKE}" ${REPO_DIR}/vendor/nim-rocksdb/scripts/build_dlls_windows.sh
+  mkdir -p ${REPO_DIR}/build
+  cp -a vendor/nim-rocksdb/build/librocksdb.dll build
+fi
+
+# Copy files to ci cache folder
+if [[ -n "$ROCKSDB_CI_CACHE" ]]; then
+  rm -rf "$ROCKSDB_CI_CACHE"
+  mkdir "$ROCKSDB_CI_CACHE"
+  cp "$BUILD_DEST"/* "$ROCKSDB_CI_CACHE"/
+fi
diff --git a/vendor/nim-rocksdb b/vendor/nim-rocksdb
@@ -1 +1 @@
-Subproject commit f420a09caca12cb173f39f8107d20600c420b9cb
+Subproject commit a95240da0f674b014d2b732539f12bed566f2446
