From 36fcb81b88c87f279cd4b46d094eb58514e9be8b Mon Sep 17 00:00:00 2001
From: Roberto Saltini <saltini.roberto@gmail.com>
Date: Tue, 18 Apr 2023 13:26:16 +1000
Subject: [PATCH] Break long statement into two statements

---
 specs/bellatrix/fork-choice.md |  3 ++-
 specs/deneb/fork-choice.md     |  3 ++-
 specs/phase0/fork-choice.md    | 15 +++++++++------
 3 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/specs/bellatrix/fork-choice.md b/specs/bellatrix/fork-choice.md
index 6c7a31508b..68519ff908 100644
--- a/specs/bellatrix/fork-choice.md
+++ b/specs/bellatrix/fork-choice.md
@@ -170,11 +170,12 @@ def on_block(store: Store, signed_block: SignedBeaconBlock) -> None:
     finalized_slot = compute_start_slot_at_epoch(store.finalized_checkpoint.epoch)
     assert block.slot > finalized_slot
     # Check block is a descendant of the finalized block at the checkpoint finalized slot
-    assert store.finalized_checkpoint.root == get_checkpoint_block(
+    finalized_checkpoint_block = get_checkpoint_block(
         store,
         block.parent_root,
         store.finalized_checkpoint.epoch,
     )
+    assert store.finalized_checkpoint.root == finalized_checkpoint_block
 
     # Check the block is valid and compute the post-state
     state = pre_state.copy()
diff --git a/specs/deneb/fork-choice.md b/specs/deneb/fork-choice.md
index 8a33fecc56..9faa11077f 100644
--- a/specs/deneb/fork-choice.md
+++ b/specs/deneb/fork-choice.md
@@ -82,11 +82,12 @@ def on_block(store: Store, signed_block: SignedBeaconBlock) -> None:
     finalized_slot = compute_start_slot_at_epoch(store.finalized_checkpoint.epoch)
     assert block.slot > finalized_slot
     # Check block is a descendant of the finalized block at the checkpoint finalized slot
-    assert store.finalized_checkpoint.root == get_checkpoint_block(
+    finalized_checkpoint_block = get_checkpoint_block(
         store,
         block.parent_root,
         store.finalized_checkpoint.epoch,
     )
+    assert store.finalized_checkpoint.root == finalized_checkpoint_block
 
     # [New in Deneb]
     # Check if blob data is available
diff --git a/specs/phase0/fork-choice.md b/specs/phase0/fork-choice.md
index a2bbb8f629..8582547fdb 100644
--- a/specs/phase0/fork-choice.md
+++ b/specs/phase0/fork-choice.md
@@ -290,13 +290,15 @@ def filter_block_tree(store: Store, block_root: Root, blocks: Dict[Root, BeaconB
             voting_source.epoch + 2 >= current_epoch
         )
 
+    finalized_checkpoint_block = get_checkpoint_block(
+        store,
+        block.parent_root,
+        store.finalized_checkpoint.epoch,
+    )
+
     correct_finalized = (
         store.finalized_checkpoint.epoch == GENESIS_EPOCH
-        or store.finalized_checkpoint.root == get_checkpoint_block(
-            store,
-            block_root,
-            store.finalized_checkpoint.epoch,
-        )
+        or store.finalized_checkpoint.root == finalized_checkpoint_block
     )
 
     # If expected finalized/justified, add to viable block-tree and signal viability to parent.
@@ -520,11 +522,12 @@ def on_block(store: Store, signed_block: SignedBeaconBlock) -> None:
     finalized_slot = compute_start_slot_at_epoch(store.finalized_checkpoint.epoch)
     assert block.slot > finalized_slot
     # Check block is a descendant of the finalized block at the checkpoint finalized slot
-    assert store.finalized_checkpoint.root == get_checkpoint_block(
+    finalized_checkpoint_block = get_checkpoint_block(
         store,
         block.parent_root,
         store.finalized_checkpoint.epoch,
     )
+    assert store.finalized_checkpoint.root == finalized_checkpoint_block    
 
     # Check the block is valid and compute the post-state
     state = pre_state.copy()