Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 2 commits
- 7 files changed
- 1 contributor
Commits on Mar 24, 2025
-
fix: dont re-create statsig metadata every time (#457)
context: StatsigMetadata contains a file read [here](https://github.com/statsig-io/java-server-sdk/blob/9310f14/src/main/kotlin/com/statsig/sdk/StatsigMetadata.kt#L22) which is only invoked on construction of a new instance Normally a single instance is constructed [here](https://github.com/statsig-io/java-server-sdk/blob/9310f14/src/main/kotlin/com/statsig/sdk/StatsigServer.kt#L303) on StatsigServerImpl instantiation, which would ensure this file read only happens once However, copies of the StatsigMetadata are being created [here](https://github.com/statsig-io/java-server-sdk/blob/9310f14/src/main/kotlin/com/statsig/sdk/StatsigLogger.kt#L122), [here](https://github.com/statsig-io/java-server-sdk/blob/9310f14/src/main/kotlin/com/statsig/sdk/StatsigLogger.kt#L165) and [here](https://github.com/statsig-io/java-server-sdk/blob/9310f14/src/main/kotlin/com/statsig/sdk/StatsigLogger.kt#L208) which seems to be re-invoking the StatsigMetadata constructor
Commits on Mar 25, 2025
-
[release] 2.0.1 - Fix statsigMetadata Re-creation (#458)
### Fixes - Fix re-creating statsigMetadata on hotpath >Included In This Release >- 99ae2c3 Weihao Ding > - fix: dont re-create statsig metadata every time (#457)
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 2.0.0...2.0.1